Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle page and query url consistently in CatalogSearchView #2113

Closed
robyngit opened this issue Mar 23, 2023 · 2 comments · Fixed by #2127
Closed

Handle page and query url consistently in CatalogSearchView #2113

robyngit opened this issue Mar 23, 2023 · 2 comments · Fixed by #2127
Assignees
Labels
Milestone

Comments

@robyngit
Copy link
Member

To make the new CatalogSearchView behaviour consistent with the old DataCatalogView, it needs to do the following:

  • In the following case, the CatalogSearchView should automatically switch back to the last viewed page of the search results: A user performs a search, switches to page n of the results, then clicks to navigate somewhere else in the app (e.g. clicks on a dataset), then clicks the back button. The url will be formatted as {REPO-URL}/data/page/{n}, and thus the search results should return to page n
  • When a user is on page n of search results and refreshes the page, the CatalogSearchView should remove the page/{n} part of the URL and return to the first page of the results. This is the current behaviour of the DataCatalogView. Alternatively, we could navigate to page n in that case.
  • When a query is appended to the end of the URL (e.g. {REPO-URL}/data/query=test), the catalog should automatically trigger a search for that query.

When fixing this issue, we should ensure that we don't re-introduce the bugs described in #971 and #723.

(Ideally the query would also be added to the URL so that a user could navigate back to the same search results, but this is an enhancement for another issue)

@robyngit
Copy link
Member Author

(Blocks #1520)

robyngit added a commit that referenced this issue Mar 24, 2023
robyngit added a commit that referenced this issue Mar 24, 2023
@robyngit
Copy link
Member Author

Complete in feature-#1720-cesium-data-catalog branch

@robyngit robyngit modified the milestones: 2.24.0, 2.25.0 May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant