Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No space between link elements when map layer moreInfoLink and downloadLink are both populated #2170

Closed
iannesbitt opened this issue Aug 2, 2023 · 1 comment
Assignees
Labels
ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center bug cesium pdg Permafrost Discovery Gateway
Milestone

Comments

@iannesbitt
Copy link
Contributor

Describe the bug
When a CesiumJs map layer has both the moreInfoLink and the downloadLink fields populated, the resulting page elements don’t have any separation between them. See below screenshot.

To Reproduce
Steps to reproduce the behavior:

  1. Example layer config in AppConfig:
    "layers": [
      {
        label: "Site1 LiDAR",
        type: "Cesium3DTileset",
        description: "Data are available for download at: https://arcticdata.io/data/10.57902/D74W2T",
        visible: false,
        moreInfoLink: "/view/urn%3Auuid%3Aed2b0fd7-2a39-42f8-883e-e9f54af1b1f2",
        downloadLink: "https://arcticdata.io/data/10.57902/D74W2T/Site1.laz",
        attribution: "",
        cesiumOptions: {
          url: "https://arcticdata.io/data/tiles/10.57902/D74W2T/Site1/tileset.json",
          foveatedConeSize: 1,
          foveatedScreenSpaceError: true,
          foveatedTimeDelay: 0.0,
          dynamicScreenSpaceError: true,
        },
      },
    ],
  2. Navigate to Cesium map
  3. Click on corresponding layer in layer picker
  4. Under INFO & DATA heading of the layer info box, resulting FULL DETAILS and DOWNLOAD DATA elements appear side-by-side with no space between.

Expected behavior
Link elements should have space between them.

Screenshots
image

Desktop (please complete the following information):

  • OS: MacOS 12.3
  • Browser: Firefox
  • Version: 114.0.2
@iannesbitt iannesbitt added the bug label Aug 2, 2023
@iannesbitt
Copy link
Contributor Author

Added context: this problem only happens when there is nothing populating the description or attribution fields. Adding one or both of those fields seems to add space between the link elements.

When attribution is added:
image

When description and attribution are added:
image

@robyngit robyngit added this to the 2.26.0 milestone Aug 3, 2023
@robyngit robyngit self-assigned this Aug 4, 2023
@robyngit robyngit added pdg Permafrost Discovery Gateway cesium labels Aug 4, 2023
robyngit added a commit that referenced this issue Aug 4, 2023
@robyngit robyngit closed this as completed Aug 4, 2023
@robyngit robyngit added ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center bug cesium pdg Permafrost Discovery Gateway
Development

No branches or pull requests

2 participants