Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map imagery disappears when navigating back to search page #2172

Closed
iannesbitt opened this issue Aug 3, 2023 · 2 comments
Closed

Map imagery disappears when navigating back to search page #2172

iannesbitt opened this issue Aug 3, 2023 · 2 comments
Labels
ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center bug
Milestone

Comments

@iannesbitt
Copy link
Contributor

iannesbitt commented Aug 3, 2023

Describe the bug
After using the search page (e.g. drp.dataone.org/data) navigating to a dataset, then using the "< Back to search" button, the imagery layer does not load correctly. Similarly, navigating to the About page and back to the Search causes a layer error. A full page refresh is needed to re-load the layer.

To Reproduce
Steps to reproduce the behavior:

  1. Go to drp.dataone.org/data or similar search page that uses Cesium map (perhaps just one that uses a Bing maps imagery layer
  2. Click on a dataset
  3. Click on "< Back to search"
  4. See blue globe and imagery layers error in console

Expected behavior
The Bing Maps imagery should be displayed on the globe.

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS
  • Browser: Firefox, Safari
  • Version: 114.0.2, 15.4

Additional context
Have not tried with other imagery layers. I suspect it's something to do with a one-time object or session going stale and being re-requested somehow, which gets fixed on full refresh because a new object/session is requested.

@iannesbitt iannesbitt added the bug label Aug 3, 2023
@robyngit
Copy link
Member

robyngit commented Aug 4, 2023

Can confirm that this is reproducible on my end

@robyngit robyngit added this to the 2.26.0 milestone Aug 4, 2023
robyngit added a commit that referenced this issue Aug 4, 2023
@robyngit
Copy link
Member

robyngit commented Aug 4, 2023

This was a bug caused by the fact that we were directly modifying the cesiumOptions (config) object while setting up the imagery layer. I fixed all map asset models so that we're only working with clones of the cesiumOptions object while setting up layers. Good catch @iannesbitt! 🎉

@robyngit robyngit closed this as completed Aug 4, 2023
@robyngit robyngit added ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADC CI-13 Dynamic data visualizations in portals (ADC deliverable) arctic data center bug
Development

No branches or pull requests

2 participants