Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portal search dropdown filters not working as expected when semantic annotations is one of the query fields #2174

Closed
robyngit opened this issue Aug 3, 2023 · 0 comments
Assignees
Labels
bug portals Anything related to portals
Milestone

Comments

@robyngit
Copy link
Member

robyngit commented Aug 3, 2023

The ADC Arctic Report Card portal's dropdown search menus used to list specific Essay and Variable choices mapped onto ontology classes. However, they are not displaying MeasurementType widgets, even though the portal XML did not change. This issue likely occurred due to a change in handling sem_annotation search filters, now rendered as a SemanticFilterView irrespective of filter type.

The SemanticFilterView is currently always rendered for filters with the sem_annotation field. However, we should specify that choiceFilter types should not be rendered as the SemanticFilterView, but a regular dropdown search view.,

@robyngit robyngit added the bug label Aug 3, 2023
@robyngit robyngit added this to the 2.26.0 milestone Aug 3, 2023
@robyngit robyngit self-assigned this Aug 3, 2023
@robyngit robyngit added the portals Anything related to portals label Aug 3, 2023
robyngit added a commit that referenced this issue Aug 3, 2023
Only render the AnnotationFilterWidget when the field is sem_annotation AND the filter type is Filter (not ChoiceFilter)

Fixes #2174
@robyngit robyngit closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug portals Anything related to portals
Projects
None yet
Development

No branches or pull requests

1 participant