Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Coordinate Input Regex Validation in EML Editor #2226

Closed
robyngit opened this issue Nov 22, 2023 · 2 comments
Closed

Issue with Coordinate Input Regex Validation in EML Editor #2226

robyngit opened this issue Nov 22, 2023 · 2 comments
Assignees
Milestone

Comments

@robyngit
Copy link
Member

An SCTLD user reported that when entering valid coordinates in the EML editor, the input field is sometimes surrounded by a red outline, indicating an issue. No error message is shown. This problem was observed with the following longitude values: -81.77270 and -81.45697.

I was able to reproduce the problem and the issue is with the pattern regex attribute in the input element. Since we have validation implemented at the model level now, this additional regex pattern seems unnecessary and potentially conflicting. It also lacks a useful error message. We should remove the pattern regex from the coordinate input elements to rely solely on the model-level validation.

@robyngit
Copy link
Member Author

Fixed in branch bug-2226-coordinate-regex. SCTLD reported that this bug prevented them from being able to submit a dataset. I was not able to reproduce that and I'm waiting for more details from that team. If, in fact, the faulty regex is preventing submission, we could consider releasing as a hotfix. Otherwise, I'll include with the next release.

@robyngit robyngit added this to the 2.28.0 milestone Nov 27, 2023
@robyngit
Copy link
Member Author

SCTLD tried again and was able to submit the dataset even with the inappropriately flagged coordinate field. I think whatever the issue was with submitting that dataset was unrelated to this issue. The fix has now been merged into main and will be included with the next release.

ianguerin pushed a commit to ianguerin/metacatui that referenced this issue Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant