Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow entry of -90 & 90 degrees latitude #2227

Closed
robyngit opened this issue Nov 27, 2023 · 2 comments
Closed

Allow entry of -90 & 90 degrees latitude #2227

robyngit opened this issue Nov 27, 2023 · 2 comments
Assignees
Milestone

Comments

@robyngit
Copy link
Member

robyngit commented Nov 27, 2023

A user recently encountered a limitation in the editor when attempting to input -90 degrees latitude. This restriction prevented the inclusion of the South Pole in their dataset, which was crucial as they had measurements from that area. The user resorted to using -89 degrees as a workaround. The decision to define -90 & 90 as invalid latitudes was based on a previous discussion (linked: #2159 (comment)), but this is too restrictive and 90 & -90 is valid EML. We should check that inclusion of the poles in the EML GeoCoverage does not have any negative consequences for the search and mapping, and fix these at the same time if needed.

@robyngit robyngit added this to the 2.28.0 milestone Nov 27, 2023
@robyngit robyngit self-assigned this Nov 27, 2023
@robyngit
Copy link
Member Author

Search-wise, datasets that contain the north or south pole are assigned an appropriate geohash.

In Cesium, those geohashes are displayed correctly:

North pole geo hash in Cesium

In the 2D Google maps, they aren't displayed very well:

North pole geo hash in google maps static North pole geo hash in google maps interactive

I'll see if there's an easy workaround for this, but I suggest that we shouldn't spend a lot of time resolving this given that we are moving toward transitioning to Cesium.

@robyngit
Copy link
Member Author

The limitation here seems to be with the Google Maps API. It seems that the imagery doesn't extend all the way to the poles. Among other parameters, I tried using different maptypes, but none worked. I propose that time is better spent using a different platform like Cesium to display static maps on the dataset landing pages. If we decide that that finding a resolution to the Google Maps display is needed, we should write up a new issue for that specific problem.

robyngit added a commit that referenced this issue Nov 27, 2023
Update EMLGeoCoverage model validation and tests

Fixes #2227
ianguerin pushed a commit to ianguerin/metacatui that referenced this issue Mar 15, 2024
Update EMLGeoCoverage model validation and tests

Fixes NCEAS#2227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant