Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cesium scale bar covers logged-in profile nav dropdown #2261

Closed
iannesbitt opened this issue Feb 7, 2024 · 1 comment · Fixed by #2263
Closed

Cesium scale bar covers logged-in profile nav dropdown #2261

iannesbitt opened this issue Feb 7, 2024 · 1 comment · Fixed by #2263
Assignees
@iannesbitt
Labels
bug cesium DRP Issues related to the Defense Resiliency Platform portals Anything related to portals
Milestone
2.28.0

Comments

@iannesbitt
Copy link
Contributor

iannesbitt commented Feb 7, 2024 •
edited

Describe the bug
On a portals page with a Cesium map, the logged-in profile nav dropdown is drawn behind the map scale bar container box.

To Reproduce
Steps to reproduce the behavior:

  1. Go to drp.dataone.org/portals/drp-data
  2. Click on Sign In button in top right and sign in with ORCiD
  3. Mouseover your name which takes the place of the Sign In button
  4. See error

Expected behavior
The dropdown should draw on top of any map-related elements.

Screenshots
Image

Desktop:

  • OS: iOS
  • Browser: Firefox
  • Version 122.0

Smartphone:

  • n/a

Additional context
To solve, the nav#Navbar element's z-level should be changed from 1 to 2 in /src/css/map-view.css metacatui.css. This is a transfer issue from NCEAS/metacatui-themes#14.
@iannesbitt iannesbitt added bug cesium DRP Issues related to the Defense Resiliency Platform portals Anything related to portals labels Feb 7, 2024
@iannesbitt iannesbitt self-assigned this Feb 7, 2024
iannesbitt added a commit that referenced this issue Feb 7, 2024
@iannesbitt
changing navbar z-index #2261
2af0f13
iannesbitt added a commit to NCEAS/metacatui-themes that referenced this issue Feb 7, 2024
@iannesbitt
removing theme navbar z-level (#14 / NCEAS/metacatui#2261)
d321f03
@iannesbitt
Copy link
Contributor Author

Robyn suggested changing this in metacatui.common.css instead, and removing the definition from each theme, which I think makes sense.

iannesbitt added a commit that referenced this issue Feb 7, 2024
@iannesbitt
adding common Navbar z-index and removing theme-specific (#2261)
f589464
@iannesbitt iannesbitt mentioned this issue Feb 7, 2024
Merged
@iannesbitt iannesbitt linked a pull request Feb 7, 2024 that will close this issue
Bugfix 2261 scale bar covers nav #2263
Merged
@iannesbitt iannesbitt mentioned this issue Feb 7, 2024
Open
@robyngit robyngit added this to the 2.28.0 milestone Feb 8, 2024
@robyngit robyngit closed this as completed Feb 8, 2024
ianguerin pushed a commit to ianguerin/metacatui that referenced this issue Mar 15, 2024
@iannesbitt @ianguerin
changing navbar z-index NCEAS#2261
8a63834
ianguerin pushed a commit to ianguerin/metacatui that referenced this issue Mar 15, 2024
@iannesbitt @ianguerin
adding common Navbar z-index and removing theme-specific (NCEAS#2261)
e918118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iannesbitt iannesbitt

Labels
bug cesium DRP Issues related to the Defense Resiliency Platform portals Anything related to portals
Projects
None yet
Milestone
2.28.0
Development

Successfully merging a pull request may close this issue.

Bugfix 2261 scale bar covers nav NCEAS/metacatui
2 participants
@iannesbitt @robyngit