Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EML Model: make system attribute configurable #441

Closed
vchendrix opened this issue Jan 11, 2018 · 3 comments
Closed

EML Model: make system attribute configurable #441

vchendrix opened this issue Jan 11, 2018 · 3 comments
Labels
ESS-DIVE Issues associated with the ESS-DIVE project good first issue A good place to start contributing to MetacatUI!
Milestone
2.26.0

Comments

@vchendrix
Copy link
Collaborator

Is it possible to make system attribute configurable in order to override the default knb value?

<eml ... system="myvalue">...</eml>
@vchendrix vchendrix added the ESS-DIVE Issues associated with the ESS-DIVE project label Jun 3, 2019
@robyngit
Copy link
Member

robyngit commented Oct 3, 2022

Hey @vchendrix, is this still an issue for ESS-DIVE? If so, could you provide a little more context for the problem? Thanks!

@vchendrix
Copy link
Collaborator Author

Sure! The following line hardcodes 'knb' we would like to configure this to populate the attribute as 'ess-dive'.

metacatui/src/js/models/metadata/eml211/EML211.js

Line 2091 in 26e1a46

eml.attr("system", "knb"); // We could make this configurable at some point

In our code base we achieve this extending EML211.createXML.

https://github.com/ess-dive/ess-dive-catalog/blob/31210a9c0ce4467f01dd9f6abaa569d286cbc9d5/theme/models/metadata/eml211/EML211.js#L49-L69

and configure it in our theme's config.js

https://github.com/ess-dive/ess-dive-catalog/blob/31210a9c0ce4467f01dd9f6abaa569d286cbc9d5/theme/config.js#L2

@robyngit robyngit added the good first issue A good place to start contributing to MetacatUI! label Oct 13, 2022
@robyngit robyngit added this to the 2.26.0 milestone Jul 13, 2023
robyngit added a commit that referenced this issue Aug 3, 2023
@robyngit
Make EML system attribute configurable in AppModel
b10ff03 
Fixes #441
@robyngit
Copy link
Member

robyngit commented Aug 3, 2023

@vchendrix this is fixed in the develop branch and will be included in the next release - sorry it took so long!

@robyngit robyngit closed this as completed Aug 3, 2023
@robyngit robyngit mentioned this issue Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ESS-DIVE Issues associated with the ESS-DIVE project good first issue A good place to start contributing to MetacatUI!
Projects
None yet
Milestone
2.26.0
Development

No branches or pull requests
2 participants
@vchendrix @robyngit