Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for Missing Value Codes and Explanations in Editor #612

Closed
maier-m opened this issue May 8, 2018 · 8 comments
Closed

Allow for Missing Value Codes and Explanations in Editor #612

maier-m opened this issue May 8, 2018 · 8 comments
Assignees
Labels
ADC CI-09 Enhanced data submission tools & portals (ADC deliverable) arctic data center attribute editor redesign New attribute section in the metadata editor editor enhancement Priority: High
Milestone

Comments

@maier-m
Copy link

maier-m commented May 8, 2018

Allow for missing value codes and explanations in the attribute editor as an enhancement to the editor.

@jagoldstein
Copy link

It would be helpful to prioritize this/ assign it to a milestone as it is the last piece of metadata that we regularly ask submitters for that does not have an entry field or a workaround in the new editor.

It seems silly to have researchers fill out everything on the webform, but then also email us missing value code explanations. While most end up sticking this in the entityDescription, it is easier for the support team to only ADD these explanations, rather than also removing them from entityDescription, thus why we prefer email.

@laurenwalker
Copy link
Member

I will assign this to 3.4.0, which is the milestone for the new attribute editor. I think at this point we're going to stop adding things to the current attribute editor and try to focus our time on the new one.

@laurenwalker laurenwalker added this to the 3.4.0 milestone Sep 26, 2018
@laurenwalker laurenwalker added the attribute editor redesign New attribute section in the metadata editor label Sep 26, 2018
@laurenwalker laurenwalker removed this from the 3.4.0 milestone Dec 26, 2019
@jeanetteclark
Copy link
Collaborator

I'm going to bump this issue with a comment, since it is something that we regularly do for PIs as part of our dataset processing

@mbjones
Copy link
Member

mbjones commented May 28, 2020

I'll second @jeanetteclark 's bump, and add a high priority label. I think this type of change would easily be added to the existing attribute editor, and so unless the attribute editor refactor can be done very quickly, this should probably be done to the existing editor first. Missing value codes are key metadata that we need to be collecting.

@laijasmine
Copy link

checking in on this issue to see if adding the missing value fields to the editor can be prioritized

@laurenwalker
Copy link
Member

Yes, I will try to get this into the next minor release

@laurenwalker laurenwalker added this to the 2.14.0 milestone Nov 6, 2020
@laijasmine
Copy link

Thanks Lauren!

@laurenwalker laurenwalker modified the milestones: 2.14.0, 2.15.0 Nov 24, 2020
@laurenwalker laurenwalker removed this from the 2.15.0 milestone Apr 6, 2021
@robyngit robyngit self-assigned this Jan 24, 2023
@robyngit robyngit added this to the 2.24.0 milestone Mar 15, 2023
@robyngit robyngit modified the milestones: 2.24.0, 2.25.0 May 5, 2023
@robyngit robyngit modified the milestones: 2.25.0, 2.26.0 May 15, 2023
@mbjones mbjones added the ADC CI-09 Enhanced data submission tools & portals (ADC deliverable) label May 17, 2023
robyngit added a commit that referenced this issue Jul 20, 2023
- Enables entering missing value codes in the Attribute editor
- Works but lacks styling & unit tests

Issue #612
robyngit added a commit that referenced this issue Jul 21, 2023
Fix two minor bugs found while testing

Issue #612
robyngit added a commit that referenced this issue Jul 21, 2023
@robyngit
Copy link
Member

This is now complete pending review in branch feature-612-missing-value-code

robyngit added a commit that referenced this issue Jul 21, 2023
robyngit added a commit that referenced this issue Aug 1, 2023
@robyngit robyngit closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ADC CI-09 Enhanced data submission tools & portals (ADC deliverable) arctic data center attribute editor redesign New attribute section in the metadata editor editor enhancement Priority: High
Development

No branches or pull requests

7 participants