Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't URLencode data on login #36

Closed
amoeba opened this issue Jun 5, 2020 · 1 comment
Closed

Don't URLencode data on login #36

amoeba opened this issue Jun 5, 2020 · 1 comment
Assignees
@amoeba

Comments

@amoeba
Copy link
Collaborator

amoeba commented Jun 5, 2020

The RT API docs specify that login/password should be escaped but it turns out they shouldn't and this breaks login for some passwords. I noticed that the Python package doesn't escape so we'll change that here.
@amoeba amoeba self-assigned this Jun 5, 2020
amoeba added a commit that referenced this issue Jun 5, 2020
@amoeba
Don't escape login/password on login request
2d92871 
Closes #36
@amoeba amoeba closed this as completed in a1f4bac Dec 17, 2020
@amoeba
Copy link
Collaborator Author

amoeba commented Dec 17, 2020

Ran into this again did more sleuthing. At first it didn't appear that the Python package encoded its form data but Python's requests library automatically form encodes whereas httr does not. Did some basic testing and this seems to work nicely now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amoeba amoeba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amoeba