Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic 1964 - Advanced select widget improvements #1964

Open
6 of 9 tasks
maradragan opened this issue Jul 9, 2019 · 0 comments · May be fixed by #3181
Open
6 of 9 tasks

Epic 1964 - Advanced select widget improvements #1964

maradragan opened this issue Jul 9, 2019 · 0 comments · May be fixed by #3181
Labels
Projects

Comments

@maradragan
Copy link
Contributor

maradragan commented Jul 9, 2019

Issues with the advanced select:

  • The advanced select widget looks different when used in the advanced search or in a form. This is because it now contains the label, the input widget and the 3rd column with recents, which makes it a field renderer instead of simply a widget. Make the advanced search a real widget, containing only the input field and the overlay.
  • The widget is now making use of the Formik Field component, this should not be the case, the Field component should only be used from forms, the widget should be independent of the use of Formik or not.
  • Not enough real estate to display pagination on filtered search / organization partially displayed (see Epic 1964: Not enough real estate to display pagination on filtered search / organization partially displayed #1810)
    Maybe this can be achieved by adding vertical scrolling to the widget?
  • Make the widget responsive

Nice to have:

  • Recent locations layout (was Recent locations layout #1648)
    The recent locations side list is pushing the atmospherics widget down. There is a lot of wasted white space.
  • Do we really want the advanced select to align left under the field label or is this just a nice to have? => nice to have

Improvements:

  • Change layout of report form on small screens (was Change layout of report form on small screens #1605)
    When we are on a small screen and the navigation bar goes to the left, do not display the recents shortcuts in forms (when the alignment of the form becomes vertical).

Filter settings for fields:

  • Update filter definition for report tasks advanced select widget (was Update filter definition for report tasks advanced select widget #1604)
    Tasks assigned to my organization should also contain tasks assigned to all parent orgs.
  • Allow super users to mark commonly used tasks for their advisor organization (was Allow super users to mark commonly used tasks for their advisor organization #1163)
    The super user for each advisor organization should be able to associate tasks with an advisor organization.
    Make it easier for advisors to select tasks for an engagement report based on:
    • The advisor organization's commander's guidance; the commander wants to focus on certain tasks.
    • What tasks have been historically chosen from the organization's advisor engagement reports
      When a report author from the organization creates a report, the tasks would be displayed for easy selection.
@maradragan maradragan added the epic label Jul 9, 2019
@maradragan maradragan added this to Triage in ANET via automation Jul 9, 2019
@maradragan maradragan changed the title Epic Advanced select widget improvements Epic 1964 - Advanced select widget improvements Jul 9, 2019
@maradragan maradragan moved this from Triage to In progress in ANET Nov 28, 2019
gjvoosten added a commit that referenced this issue Feb 20, 2020
gjvoosten added a commit that referenced this issue Feb 20, 2020
@VassilIordanov VassilIordanov added this to Triage in ANET Backlog via automation Mar 31, 2020
@VassilIordanov VassilIordanov removed this from In progress in ANET Mar 31, 2020
@VassilIordanov VassilIordanov moved this from Triage to Confirmed in ANET Backlog Mar 31, 2020
@VassilIordanov VassilIordanov added this to Triage in ANET via automation May 14, 2020
@VassilIordanov VassilIordanov removed this from Confirmed in ANET Backlog May 14, 2020
@VassilIordanov VassilIordanov moved this from Triage to Confirmed in ANET May 14, 2020
gjvoosten added a commit that referenced this issue Sep 3, 2020
gjvoosten added a commit that referenced this issue Sep 3, 2020
gjvoosten added a commit that referenced this issue Sep 7, 2020
gjvoosten added a commit that referenced this issue Sep 7, 2020
gjvoosten added a commit that referenced this issue Sep 17, 2020
gjvoosten added a commit that referenced this issue Sep 17, 2020
gjvoosten added a commit that referenced this issue Sep 24, 2020
gjvoosten added a commit that referenced this issue Sep 24, 2020
gjvoosten added a commit that referenced this issue Dec 10, 2020
gjvoosten added a commit that referenced this issue Dec 10, 2020
gjvoosten added a commit that referenced this issue Dec 10, 2020
So you can run the test multiple times.
gjvoosten added a commit that referenced this issue Dec 10, 2020
Note: more space can be used by changing to the full width (9 ⇒ 12).
@VassilIordanov VassilIordanov moved this from Confirmed to Triage in ANET Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
ANET
  
Triage
Development

Successfully merging a pull request may close this issue.

1 participant