Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move recents to advanced select filters; drop rightmost column in forms #3181

Draft
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Sep 3, 2020

Show the links to recent locations, attendees, efforts and authorization groups as the first filter under the selection widget when editing a report. This puts all filters in one place, and no longer limits the list of recent items to the 6 most recent ones. It also does away with the extra empty space the table of recent items created.

Release notes

Closes #1964

User changes

  • When editing a report, you can now find the recently used items under the selection filters of the corresponding input field.

Super User changes

  • none

Admin changes

  • none

System admin changes

  • none
  • anet.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten marked this pull request as ready for review September 7, 2020 11:29
Copy link
Contributor

@cemalettin-work cemalettin-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add recents tab to the advanced selects in the Engagement Information part for consistency ? I am talking about here
engagment-info-recents

client/src/components/FieldHelper.js Outdated Show resolved Hide resolved
@gjvoosten
Copy link
Collaborator Author

Should we also add recents tab to the advanced selects in the Engagement Information part for consistency ? I am talking about here
engagment-info-recents

In my opinion: no.

@cemalettin-work
Copy link
Contributor

Should we also add recents tab to the advanced selects in the Engagement Information part for consistency ? I am talking about here
engagment-info-recents

In my opinion: no.

Maybe a little bit more insight into why "no" would be nicer. Is it because that it is not a requested change or that that part has a conceptually different use case ?

@gjvoosten
Copy link
Collaborator Author

Should we also add recents tab to the advanced selects in the Engagement Information part for consistency ?

In my opinion: no.

Maybe a little bit more insight into why "no" would be nicer. Is it because that it is not a requested change or that that part has a conceptually different use case ?

It is not part of the story and there has been no request for it. If and when a need arises, this should be done as a separate story, as it could get quite involved. Which recents do you show there? There is currently no easy way to search inside custom fields; that would require JSON query paths etc.

@midmarch midmarch removed the request for review from maradragan September 16, 2021 11:22
@gjvoosten gjvoosten marked this pull request as draft February 16, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epic 1964 - Advanced select widget improvements
2 participants