Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all locations layer to the map #3056

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add all locations layer to the map #3056

wants to merge 3 commits into from

Conversation

ysf-simsoft
Copy link
Contributor

When the map component is loaded, all locations are fetched and added to the existing layer control as an overlay. Adding as an overlay gives us the ability to toggle all locations layer. By default when all locations layer is added to the map, we automatically adjust zoom level to make all locations visible. Exceptionally, while editing/creating a location we preserve the current zoom level in order not to fly user away from current location/area.

Additionally when there are other markers on the map we keep them and put new markers for all locations. This results in duplicate markers on already existing markers, however, we use a different icon for all locations overlay so that even there are two markers on same point they are displayed differently, serving different purposes.

Release notes

Closes #3045

User changes

  • All locations layer is added to the map

Super User changes

  • none

Admin changes

  • none

System admin changes

  • none

  • anet.yml needs change

  • db needs migration

  • documentation has changed

  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@ysf-simsoft ysf-simsoft added this to the 2020 June milestone Jun 11, 2020
@ysf-simsoft ysf-simsoft self-assigned this Jun 11, 2020
@ysf-simsoft ysf-simsoft removed this from the 2020 June milestone Jun 11, 2020
@ysf-simsoft ysf-simsoft force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from e7ffde2 to 7b8d1a8 Compare June 13, 2020 11:53
@ysf-simsoft ysf-simsoft force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from 7b8d1a8 to 4850220 Compare June 23, 2020 08:27
@ysf-simsoft ysf-simsoft marked this pull request as ready for review June 25, 2020 09:09
VassilIordanov
VassilIordanov previously requested changes Jun 27, 2020
View reviewed changes
Copy link
Contributor

@VassilIordanov VassilIordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of the png files is never used

@ysf-simsoft ysf-simsoft force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from b5c9bc2 to 9e3cfe7 Compare June 29, 2020 11:03
@ysf-simsoft ysf-simsoft mentioned this pull request Jun 30, 2020
Draft
14 tasks
@ysf-simsoft ysf-simsoft force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from 9e3cfe7 to fa86e0c Compare July 9, 2020 18:19
@ysf-simsoft ysf-simsoft force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from fa86e0c to 6eae0bf Compare July 24, 2020 07:52
@ysf-simsoft ysf-simsoft force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from 6eae0bf to 8e76c13 Compare August 22, 2020 18:50
@cemalettin-work cemalettin-work force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from 8e76c13 to 06780cb Compare October 12, 2020 12:09
@cemalettin-work cemalettin-work self-assigned this Oct 26, 2020
@ysf-simsoft ysf-simsoft force-pushed the GH-3045-add-all-locations-layer-to-the-map branch 2 times, most recently from 14c7da3 to 8652ed2 Compare November 26, 2020 09:03
@cemalettin-work cemalettin-work force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from 8652ed2 to 94de62c Compare December 14, 2020 10:37
@cemalettin-work cemalettin-work force-pushed the GH-3045-add-all-locations-layer-to-the-map branch 2 times, most recently from ce5f399 to 4b01b02 Compare December 28, 2020 06:24
@cemalettin-work cemalettin-work force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from 4b01b02 to 3601651 Compare January 14, 2021 10:58
@gjvoosten gjvoosten removed the request for review from maradragan February 24, 2021 13:03
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from 3601651 to a0907db Compare September 24, 2021 12:06
@gjvoosten gjvoosten requested review from midmarch and removed request for gjvoosten December 23, 2021 13:46
@anilsonmez-simsoft anilsonmez-simsoft force-pushed the GH-3045-add-all-locations-layer-to-the-map branch from a0907db to e50becf Compare March 1, 2022 14:08
@gjvoosten gjvoosten marked this pull request as draft February 16, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten left review comments

@cemalettin-work cemalettin-work cemalettin-work left review comments

@VassilIordanov VassilIordanov VassilIordanov left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a locations layer to the map for displaying all locations
4 participants
@ysf-simsoft @gjvoosten @VassilIordanov @cemalettin-work