Create diagram as part of note #3934
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anilsonmez-simsoft
force-pushed
the
AB-245-create-diagram-as-part-of-note
branch
3 times, most recently
from
3faac80
to
f4f1301
Compare
anilsonmez-simsoft
requested review from
gjvoosten,
asafkaganbezgin and
ny-simsoft
anilsonmez-simsoft
force-pushed
the
AB-245-create-diagram-as-part-of-note
branch
from
681069a
to
662110a
Compare
anilsonmez-simsoft
force-pushed
the
AB-245-create-diagram-as-part-of-note
branch
from
662110a
to
f920100
Compare
gjvoosten
requested changes
Dec 20, 2021
| @@ -7,7 +8,6 @@ import AdminIndex from "pages/admin/Index" | |||
| import MergeLocations from "pages/admin/MergeLocations" | |||
| import MergePeople from "pages/admin/MergePeople" | |||
| import MergePositions from "pages/admin/MergePositions" | |||
| import BoardDashboard from "pages/dashboards/BoardDashboard" | |||
There was a problem hiding this comment.
This is still used as a page in this file, so it should stay under pages/.
| // Make sure we have a navigation menu | ||
| useBoilerplate({ |
There was a problem hiding this comment.
This is still used as a page in Routing.js, so it should stay under pages/, and also use the boilerplate.
| import { Button, Modal } from "react-bootstrap" | ||
| import utils from "utils" | ||
| import * as yup from "yup" | ||
| import "./Diagrams.css" |
There was a problem hiding this comment.
To avoid clutter, generic diagramming components might be placed in a sub-directory src/components/diagrams/.
gjvoosten
requested review from
midmarch
and removed request for
asafkaganbezgin and
ny-simsoft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagrams can be saved as a note of type
DIAGRAM. These diagrams can be seen on the show pages of the related ANET entity.Closes AB#245
User changes
Super User changes
Admin changes
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules