Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dictionary keys to more logical place #4851

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

gjvoosten
Copy link
Collaborator

@gjvoosten gjvoosten commented Jul 3, 2024

Closes AB#1165

User changes

  • None

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • anet.yml or anet-dictionary.yml needs change
    • Move the key fields.regular.position.location.filter to fields.position.location.filter
    • Move the key fields.regular.position.organizationsAdministrated to fields.position.organizationsAdministrated
    • Move the key fields.regular.org.location.filter to fields.organization.location.filter
    • Move the key fields.regular.org.administratingPositions to fields.organization.administratingPositions
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • Described the user behavior in PR body
  • Referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • Added and/or updated unit tests
  • Added and/or updated e2e tests
  • Added and/or updated data migrations
  • Updated documentation
  • Resolved all build errors and warnings
  • Opened debt issues for anything not resolved here

@gjvoosten gjvoosten force-pushed the AB-1165-move-dictionary-keys branch from 4364a73 to fbdc9da Compare July 3, 2024 09:23
@gjvoosten gjvoosten marked this pull request as ready for review July 3, 2024 09:42
@gjvoosten gjvoosten force-pushed the AB-1165-move-dictionary-keys branch from fbdc9da to 2c97dfc Compare July 3, 2024 11:52
@gjvoosten gjvoosten merged commit 9437bd5 into main Jul 4, 2024
21 checks passed
@gjvoosten gjvoosten deleted the AB-1165-move-dictionary-keys branch July 4, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants