remove parent tag caching #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulgan
commented
Dec 7, 2021
| @@ -20,6 +28,7 @@ def __generate_hash(seed, label): | |||
| return six.ensure_str(str(uuid.uuid5(namespace, name))) | |||
|
|
|||
|
|
|||
| @lru_cache(maxsize=None) | |||
There was a problem hiding this comment.
caches based on hash, see impl
qiaouchicago
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: tag computation relies on the previously computed tag of the parent node, sometimes this value can be wrong even when trying to fix the generated tag, sometimes the old tag (wrong tag) is used instead of the newly fixed tags. This happened a lot during export of the v36 nodes.
Fix: remove the use of the parent's tag and force a complete recompute every time.