DEV-1035: Add support for skipping nodes during tagging/versioning #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpsolano
approved these changes
May 17, 2022
gdcdatamodel/models/__init__.py
Outdated
| """Tagging configuration instance used for checking if node instance participates in versioning | ||
|
|
||
| Returns: | ||
| versioning.TaggingConfig): config instance |
There was a problem hiding this comment.
Suggested change
| versioning.TaggingConfig): config instance | |
| versioning.TaggingConfig: config instance |
gdcdatamodel/models/versioning.py
Outdated
|
|
||
|
|
||
| class TaggingConfig: | ||
| """A wrapper around the tagConfig definition in the dictionary yaml""" |
There was a problem hiding this comment.
Should the docstring reference tagBuilderConfig?
qiaouchicago
approved these changes
May 18, 2022
XukunXiangUChicago
approved these changes
May 20, 2022
Comment on lines
166
to
+170
| table = node.__table__ | ||
|
|
||
| if not node.is_taggable(): | ||
| return # do nothing | ||
|
|
There was a problem hiding this comment.
nit picking:
Suggested change
| table = node.__table__ | |
| if not node.is_taggable(): | |
| return # do nothing | |
| if not node.is_taggable(): | |
| return # do nothing | |
| table = node.__table__ |
| @@ -17,6 +17,8 @@ | |||
| import os | |||
| import sys | |||
|
|
|||
| import six | |||
There was a problem hiding this comment.
We are still supporting python 2?
There was a problem hiding this comment.
Sadly we are, biowcs is still py2 and it is a mojor player for GPAS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add implementation that ignores nodes with certain values for certain fields while generating a tag. These fields are configured via the dictionary. A sample configuration is also included for testing purposes.