Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRTL-2544 add data for Box Plot + Table #2533

Merged
merged 2 commits into from May 8, 2019
Merged

PRTL-2544 add data for Box Plot + Table #2533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2cd2528
PRTL-2545 apply initial linting at ClinicalVariableCard
justincorrigible Apr 29, 2019
93f0e4b
PRTL-2544 fetch data for box plot + table
justincorrigible May 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 20 additions & 4 deletions .eslintrc.js
View file
Open in desktop
Expand Up @@ -27,12 +27,19 @@ module.exports = {
},
plugins: [
'@typescript-eslint',
'react'
'react',
'react-hooks',
// 'jest'
],
rules: {
'array-bracket-newline': ['error', { 'multiline': true, 'minItems': 3 }],
'array-element-newline': ['warn', { 'multiline': true, 'minItems': 3 }],
'array-bracket-newline': ['error', {
'multiline': true,
'minItems': 3,
}],
'array-element-newline': ['warn', {
'multiline': true,
'minItems': 3,
}],
'arrow-body-style': 'off',
'arrow-parens': 'off',
'camelcase': 'warn',
Expand Down Expand Up @@ -61,11 +68,13 @@ module.exports = {
'JSXSpreadAttribute',
'JSXSpreadChild',
'JSXText',
'TemplateLiteral > *',
],
ImportDeclaration: 'first',
MemberExpression: 1,
ObjectExpression: 'first',
SwitchCase: 1,
VariableDeclarator: 'first',
}],
'no-console': ['warn', {
allow: [
Expand Down Expand Up @@ -109,12 +118,19 @@ module.exports = {
}],
'padded-blocks': 'error',
'semi': ['warn', 'always'],
'sort-keys': ['warn', 'asc', {
caseSensitive: false,
natural: true,
}],
'quotes': ['warn', 'single'],
'import/no-extraneous-dependencies': ['warn', {
'packageDir': './'
}],
'react/jsx-indent-props': ['warn', 2],
'react/jsx-closing-bracket-location': ['warn', 'props-aligned'],
'react/jsx-indent': ['warn', 2, {
checkAttributes: true,
// indentLogicalExpressions: true,
}],
'react/jsx-indent-props': ['warn', 'first'],
'react/jsx-max-props-per-line': ['warn', {
maximum: 1,
Expand Down
6 changes: 6 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -104,6 +104,7 @@
"eslint-plugin-import": "2.17.2",
"eslint-plugin-jsx-a11y": "6.2.1",
"eslint-plugin-react": "7.12.4",
"eslint-plugin-react-hooks": "1.6.0",
"flow-bin": "0.61.0",
"react-app-rewired": "1.6.2",
"react-scripts-ts": "3.1.0",
Expand Down
4 changes: 2 additions & 2 deletions src/packages/@ncigdc/modern_components/ClinicalAnalysis/ClinicalAnalysisResult.js
View file
Open in desktop
Expand Up @@ -26,13 +26,13 @@ import Hidden from '@ncigdc/components/Hidden';
import { visualizingButton } from '@ncigdc/theme/mixins';
import { zDepth1 } from '@ncigdc/theme/mixins';
import EntityPageHorizontalTable from '@ncigdc/components/EntityPageHorizontalTable';
import ClinicalVariableCard from './ClinicalVariableCard.js';
import ClinicalVariableCard from './ClinicalVariableCard';
import ContinuousAggregation from './ContinuousAggregationQuery';
import Input from '@ncigdc/uikit/Form/Input';
import { withTheme } from '@ncigdc/theme';
import countComponents from '@ncigdc/modern_components/Counts';
import ExploreLink from '@ncigdc/components/Links/ExploreLink';
import ControlPanelNode from './ControlPanelNode.js';
import ControlPanelNode from './ControlPanelNode';
import {
updateClinicalAnalysisProperty,
addAnalysis,
Expand Down