Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metatag submodules, cgov_metatag, config exclusions, field storage #1509

Merged

Conversation

adriancofie
Copy link
Collaborator

@adriancofie adriancofie commented Apr 17, 2019

Adds and enables the following modules:

  • cgov_metatag

Enables the following sub modules:

  • metatag_dc
  • metatag_dc_advanced
  • metatag_open_graph
  • metatag_twitter_cards

Adds the following config checker exclusions:
'metatag.metatag_defaults.global',
'metatag.metatag_defaults.node',

Closes #185 by adding the following

  • Browser Title element
  • Meta Description
  • Search Engine Restrictions Logic. (Adds no index tag based on the node field value)
    NOTE: The S.E logic will only work for content types that have added a field of type metatag. This PR adds it for article only. When added for the remaining types, this logic will automatically work for them also.

Closes #197 OpenGraph Tabs by adding the following:

  • og:title
  • og:description
  • og:type
  • og:url
  • og:sitename
  • twitter:card

Closes #195 HREF TAG

  • (This HREF Lang functionality has actually been in develop for a while and just needs to be verified.)

Partially addressing #196

  • Add dcterms.type for Article
    Note: Each content type will need to add a field of type 'metatag' and it's related configuration in the module for the tag to appear .

@adriancofie
Copy link
Collaborator Author

@adriancofie adriancofie added this to the Sprint 11 milestone Apr 19, 2019
@adriancofie adriancofie added the Needs UX Review Identifies a PR as needing IA Review label Apr 19, 2019
@VictoriaSunNIH VictoriaSunNIH added Does Not Pass UX Review Failed IA review/testing and removed Needs UX Review Identifies a PR as needing IA Review labels Apr 19, 2019
@VictoriaSunNIH
Copy link

@adriancofie - we need to discuss what other stories need to be put in for this one. I also tested exclude from search on an article and did not see the "noindex" value in the view source.

@adriancofie adriancofie force-pushed the feature/metatags-article-field branch from d6d0a11 to 3a33ee1 Compare April 24, 2019 16:17
@adriancofie adriancofie removed the Does Not Pass UX Review Failed IA review/testing label Apr 24, 2019
@adriancofie adriancofie force-pushed the feature/metatags-article-field branch 2 times, most recently from cdb07d8 to 6bdc7f3 Compare April 24, 2019 17:03
@adriancofie
Copy link
Collaborator Author

Updating with latest from develop.

@adriancofie
Copy link
Collaborator Author

Per convo with @VictoriaSunNIH I'm going to attempt to add the metatag field to each content type within this PR.

@adriancofie adriancofie force-pushed the feature/metatags-article-field branch 4 times, most recently from 19378f9 to 7aa6b89 Compare April 25, 2019 18:34
@VictoriaSunNIH
Copy link

VictoriaSunNIH commented Apr 29, 2019

@adriancofie - I've tested all of the metadata out on all of the content types.

For node/page types:

  • CTHP, Mini Landing Page and Cancer Research List pages are missing their dcterms.type in the metadata

For Media Types:

@adriancofie adriancofie force-pushed the feature/metatags-article-field branch from 7aa6b89 to b8168d1 Compare April 29, 2019 17:00
@adriancofie adriancofie force-pushed the feature/metatags-article-field branch 2 times, most recently from f605b37 to 01aa8de Compare April 29, 2019 17:01
@adriancofie adriancofie force-pushed the feature/metatags-article-field branch from 01aa8de to f981762 Compare April 29, 2019 19:03
@VictoriaSunNIH
Copy link

This looks good! Passes IA review!

@VictoriaSunNIH VictoriaSunNIH added Passed UX Review For Pull Requests that had passed "product" review and removed Needs UX Review Identifies a PR as needing IA Review labels Apr 29, 2019
@bryanpizzillo bryanpizzillo merged commit 4388118 into NCIOCPL:develop Apr 29, 2019
End of Dev Stories automation moved this from In progress to Done Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed UX Review For Pull Requests that had passed "product" review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Output Page Metadata - Open Graph Tags Output Page Metadata - Href Lang Output Page Metadata - SEO
6 participants