Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample pages on example site and storybook with content from cgov-digital-platform #1026

Closed
6 tasks done
sarinapadilla opened this issue Jun 7, 2023 · 4 comments · Fixed by #1065
Closed
6 tasks done
Assignees
Labels
Change Request Request to update or change existing requirements

Comments

@sarinapadilla
Copy link

sarinapadilla commented Jun 7, 2023

Change Request Description

The requested change is to update the Example site so that it matches the ODE exactly to improve testing. The pages to be updated on the Example site and their equivalent on the ODE are listed below.

Expected Change

Update the following on the Example Site (https://designsystem-dev.cancer.gov/develop/example-site/)

Acceptance Criteria

Scenario: The DS Example Site matches the test pages on the ODE
Given a user is viewing the DS Example Site
Then the DS Example Site exactly matches the test pages on the ODE

Screenshots/Additional Notes

@sarinapadilla sarinapadilla added this to the R2 - DS Iteration 19 milestone Jun 7, 2023
@andyvanavery andyvanavery added the Change Request Request to update or change existing requirements label Jun 16, 2023
karlikpj added a commit that referenced this issue Jun 21, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 21, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 22, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 22, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 22, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 22, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 22, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 22, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 22, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 22, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 23, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 23, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 23, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Jun 23, 2023
Closes #1026

Updating content on example pages to match active site
@bennettcc
Copy link

Based on internal conversation on 6/27, this story is on hold. Action items to follow:

  • Monika replace homepage png images to be jpegs (where required) on ACSF test
  • Bryan retest page speed on acsf-test after Monika's images changes
  • Monika + Laurel replace images in Prod CMS (and shared teams folders used by content team) ahead of 7/13 content launch (so the correct jpegs are added into the new c.gov launched pages)
  • Laurel create design backlog ticket to develop documentation/guidance for when jpegs vs pngs should be used on c.gov/microsites
  • Sarina/Andy create digi platform GH ticket to update YAML with new jpeg images (to match what Monika is changing on acsf and eventually prod)

@laurelthrash
Copy link
Contributor

laurelthrash commented Jul 13, 2023

Determined during 7/13 UX meeting that we need to provide the following:

  1. Link to folder with images (@monika-jaeger )
  2. Link to content templates: https://nih.sharepoint.com/:f:/r/sites/NCI-OCPLNewCgovUXDesignSystem/Shared%20Documents/General/Details%20-%20Release%202/R2.1/Content%20Templates?csf=1&web=1&e=i2zFxX

Team to reference content that is published to production on 7/13. Cc: @bennettcc @sarinapadilla

@monika-jaeger
Copy link

karlikpj added a commit that referenced this issue Aug 23, 2023
karlikpj added a commit that referenced this issue Aug 23, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 23, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 25, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 25, 2023
Closes #1026

Updating content on example pages to match active site
@bennettcc bennettcc added Needs Technical Review Needs review from Architect and Development Needs Product Review Needs review from Product, QA, Design, and IA labels Aug 25, 2023
karlikpj added a commit that referenced this issue Aug 28, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 28, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 28, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 28, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 29, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 29, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 29, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 30, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 30, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 30, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 30, 2023
Closes #1026

Updating content on example pages to match active site
@bennettcc bennettcc removed the Needs Product Review Needs review from Product, QA, Design, and IA label Aug 30, 2023
karlikpj added a commit that referenced this issue Aug 31, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Aug 31, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Sep 5, 2023
Closes #1026

Updating content on example pages to match active site
karlikpj added a commit that referenced this issue Sep 6, 2023
Closes #1026

Updating content on example pages to match active site.
Removing NCI from hero/cta strip.
Fixing Promo Block titles.
karlikpj added a commit that referenced this issue Sep 6, 2023
Closes #1026

Updating content on example pages to match active site.
Removing NCI from hero/cta strip.
Fixing Promo Block titles.
arcepaul pushed a commit that referenced this issue Sep 7, 2023
Closes #1026

Updating content on example pages to match active site.
Removing NCI from hero/cta strip.
Fixing Promo Block titles.
@bennettcc bennettcc removed the Needs Technical Review Needs review from Architect and Development label Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Request Request to update or change existing requirements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants