Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the Distinguishability of the Default and Hover States of Secondary Buttons #1086

Closed
andyvanavery opened this issue Jun 29, 2023 · 2 comments · Fixed by #1100
Closed
Assignees
Labels
Change Request Request to update or change existing requirements DS Release 2.3

Comments

@andyvanavery
Copy link

andyvanavery commented Jun 29, 2023

Change Request Description

Request to change the color of the hover state of the buttons on Guide Cards for improved visibility. The differences between default and hover are difficult to distinguish. The colors currently used are:

  • Default: #298085 (success-dark or teal-50)
  • Hover: #226467 (secondary-dark or teal-60)
  • Active: #1E4C4F (success-darker or teal-70)

What's the expected change?

  • Improve the distinguishability between the Default and Hover states of secondary buttons; please use the below updated Figma file for color values:

https://www.figma.com/proto/PglDgHtAXt59f52jVOseIu/GitHub-Ticket-%231086---Buttons?page-id=0%3A1&type=design&node-id=1-2&viewport=269%2C76%2C1&t=fGp9hQZS4BvFX1Qe-1&scaling=min-zoom

What's the current functionality?

  • Default: #298085 (success-dark or teal-50)
  • Hover: #226467 (secondary-dark or teal-60)

What's the updated acceptance criteria?

Scenario: A user is viewing a Guide Card on an example site
Given a Guide Card has been created on an example site
  And the user is viewing the example site
Then the user will be able to clearly distinguish between Default and Hover states of the secondary buttons on the Guide Cards

Additional details / screenshot

Related Tickets

@andyvanavery andyvanavery added the Change Request Request to update or change existing requirements label Jun 29, 2023
@andyvanavery andyvanavery added this to the R2 - DS Iteration 21 milestone Jun 30, 2023
@monika-jaeger
Copy link

Adding link for Figma example with buttons for what we discussed during Weekly Requirements Discussions 7/6/23

@bennettcc bennettcc added Needs Product Review Needs review from Product, QA, Design, and IA Needs Technical Review Needs review from Architect and Development labels Jul 7, 2023
dlescarbeau added a commit that referenced this issue Jul 10, 2023
dlescarbeau added a commit that referenced this issue Jul 10, 2023
@bennettcc bennettcc removed the Needs Product Review Needs review from Product, QA, Design, and IA label Jul 10, 2023
arcepaul pushed a commit that referenced this issue Jul 11, 2023
@bennettcc bennettcc removed the Needs Technical Review Needs review from Architect and Development label Jul 11, 2023
arcepaul pushed a commit that referenced this issue Jul 11, 2023
@alinai
Copy link

alinai commented Jul 27, 2023

This looks good to me. cc: @KateMashkinaNIH

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change Request Request to update or change existing requirements DS Release 2.3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants