Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCIDS Documentation Site: Fix font-family on Foundations, Typography, Font Size #1430

Closed
andyvanavery31 opened this issue Dec 6, 2023 · 0 comments · Fixed by #1489
Closed
Assignees
Labels
Bug Something isn't functioning or displaying per established requirements Documentation Improvements or additions to documentation

Comments

@andyvanavery31
Copy link

Bug Description

On the NCIDS Documentation Site, under Foundations, Typography, Font Size and Family, the Font Family table has a typo where all "font-family" is written as "font-faimly" and therefore the wrong fonts are displayed. This ticket is to track fixing the wording in the table and ensuring that the correct font is displayed. Go to https://designsystem-dev.cancer.gov/develop/foundations/typography/fonts#font-family to see the issue.

Steps to reproduce the issue

  1. Go to https://designsystem-dev.cancer.gov/develop/foundations/typography/fonts#font-family
  2. View the table in this section
  3. Identify that the "font-family" in column 1 is spelled "font-faimly" and that the text in column 2 is not displaying the correct font family.

What's the expected result?

  • The table in the link above displays the corrected text to "font-family" and the example displays the correct font family.

What's the actual result?

  • The typo and incorrect font family are displayed
@andyvanavery31 andyvanavery31 added Bug Something isn't functioning or displaying per established requirements Documentation Improvements or additions to documentation labels Dec 6, 2023
karlikpj added a commit that referenced this issue Jan 22, 2024
arcepaul pushed a commit that referenced this issue Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't functioning or displaying per established requirements Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants