Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating color changes on NCIDS Token Changes from USWDS page on NCIDS Documentation Site #1532

Closed
blilianyu opened this issue Feb 15, 2024 · 0 comments · Fixed by #1536
Closed

Updating color changes on NCIDS Token Changes from USWDS page on NCIDS Documentation Site #1532

blilianyu opened this issue Feb 15, 2024 · 0 comments · Fixed by #1536
Assignees
@blilianyu
Labels
Change Request Request to update or change existing requirements Documentation Improvements or additions to documentation Needs Technical Review Needs review from Architect and Development

Comments

@blilianyu
Copy link
Contributor

blilianyu commented Feb 15, 2024 •
edited

Issue description

This change is requested to update General Color Changes and More Specific Color Changes on NCIDS Token Changes from USWDS page on NCIDS Documentation Site

What's the expected change?

Change to generic color family

  • General Color Changes (Add link to Foundations/Color#Theme Tokens)

    • $theme-color-primary-family blue -> cerulean
    • $theme-color-secondary-family red -> teal
    • $theme-color-accent-warm-family orange -> golden
    • $theme-color-accent-cool-family blue-cool -> navy

  • More Specific Color Changes (Add link to Foundations/Color#State Tokens)

    • $theme-color-error-family red-warm -> cranberry
    • $theme-color-warning-family gold -> golden
    • $theme-color-success-family green-cool -> teal
    • $theme-color-info-family cyan -> cerulean
    • $theme-color-emergency red-warm-60v -> cranberry-60v
    • $theme-color-emergency-dark red-warm-80 -> cranberry-80
    • $theme-link-color primary to cerulean-60v

What's the current functionality?

  • Call out specific hex code changes

Related Tickets
@blilianyu blilianyu added Change Request Request to update or change existing requirements Documentation Improvements or additions to documentation labels Feb 15, 2024
blilianyu added a commit that referenced this issue Feb 15, 2024
@blilianyu
(#1532) Updating color token hex codes on the Foundations Color page …
5e30ba3 
…on NCIDS Documentation Site

Closes #1532

Updated emergency, base-darkest, primary-dark, primary-darker, cerulean-70, cerulean-80, cranberry-10v and teal-40 hex codes.
@blilianyu blilianyu mentioned this issue Feb 15, 2024
Merged
@blilianyu blilianyu self-assigned this Feb 15, 2024
blilianyu added a commit that referenced this issue Feb 16, 2024
@blilianyu
(1532) Updating color changes on NCIDS Token Changes from USWDS
4a10586 
Closes #1532 

Updated General Color Changes and More Specific Color Changes tables
This was referenced Feb 16, 2024
Closed
Closed
blilianyu added a commit that referenced this issue Feb 16, 2024
@blilianyu
(#1532) Updating color changes on NCIDS Token Changes from USWDS
5d876ee 
Closes #1532

Updated General Color Changes and More Specific Color Changes tables
@blilianyu blilianyu mentioned this issue Feb 16, 2024
Merged
karlikpj pushed a commit that referenced this issue Feb 16, 2024
@blilianyu @karlikpj
(#1532) Updating color changes on NCIDS Token Changes from USWDS
915ff13 
Closes #1532

Updated General Color Changes and More Specific Color Changes tables
blilianyu added a commit that referenced this issue Feb 16, 2024
@blilianyu
(#1532) Updating color changes on NCIDS Token Changes from USWDS
b0fc22f 
Closes #1532

Updated General Color Changes and More Specific Color Changes tables
@blilianyu blilianyu mentioned this issue Feb 16, 2024
Closed
@bennettcc bennettcc added the Needs Technical Review Needs review from Architect and Development label Feb 21, 2024
olitharp-nci pushed a commit that referenced this issue Feb 22, 2024
@blilianyu @olitharp-nci
(#1532) Updating color changes on NCIDS Token Changes from USWDS
fa3ec63 
Closes #1532

Updated General Color Changes and More Specific Color Changes tables
olitharp-nci pushed a commit that referenced this issue Feb 22, 2024
@blilianyu @olitharp-nci
(#1532) Updating color changes on NCIDS Token Changes from USWDS
b1a7591 
Closes #1532

Updated General Color Changes and More Specific Color Changes tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blilianyu blilianyu

Labels
Change Request Request to update or change existing requirements Documentation Improvements or additions to documentation Needs Technical Review Needs review from Architect and Development
Projects
None yet
Milestone
No milestone
2 participants
@bennettcc @blilianyu