Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari: Site alert caret to expand is missing #616

Closed
bennettcc opened this issue Oct 7, 2022 · 3 comments · Fixed by #878
Closed

Safari: Site alert caret to expand is missing #616

bennettcc opened this issue Oct 7, 2022 · 3 comments · Fixed by #878
Assignees
Labels
Bug Something isn't functioning or displaying per established requirements DS Development

Comments

@bennettcc
Copy link

bennettcc commented Oct 7, 2022

Basic Information

  • Issue: Safari - the caret pointing downward and upward when expanding and collapsing the alert is missing
  • Desired Outcome: caret should be displayed

ESTIMATE: 2

Steps to Reproduce

  1. add standard NCI site alert and place block
  2. navigate to any page on Safari
  3. the alert can be expanded by clicking on it, but no caret present

Screen Shots

Image

Image

@bennettcc bennettcc added Bug Something isn't functioning or displaying per established requirements Drupal - Redesign labels Oct 7, 2022
@sarinapadilla sarinapadilla transferred this issue from NCIOCPL/cgov-digital-platform Oct 13, 2022
@sarinapadilla sarinapadilla added the SP:2 2 Story Points label Nov 10, 2022
@bennettcc bennettcc added this to the DS Sprint 43 milestone Nov 17, 2022
@bennettcc
Copy link
Author

Per discussion with @arcepaul - this ticket will not require a change to platform code. Instead, this is a content fix that can be made by updating the content markup.

@bennettcc bennettcc removed this from the DS Sprint 43 milestone Nov 18, 2022
@arcepaul
Copy link
Contributor

arcepaul commented Dec 2, 2022

The svg for the arrow icon will just need to be changed to the following:

<svg class="usa-icon" role="img" aria-hidden="true" viewBox="0 0 64 39" xmlns="http://www.w3.org/2000/svg">
<path fill="currentColor" d="M.655 34.187c-.427-.437-.64-.937-.64-1.503 0-.566.213-1.067.64-1.502L30.542.756c.427-.436.918-.653 1.474-.653.555 0 1.048.218 1.474.653l29.884 30.426c.428.435.642.936.642 1.502s-.213 1.066-.642 1.501l-3.206 3.265c-.427.436-.919.653-1.475.653-.555 0-1.047-.217-1.475-.653L32.016 11.79 6.81 37.45c-.427.436-.919.653-1.474.653-.556 0-1.048-.217-1.475-.653L.655 34.187z"></path>
</svg>

arcepaul pushed a commit that referenced this issue Dec 2, 2022
- also apply icon fix to close site alert to relevant stories
arcepaul pushed a commit that referenced this issue Dec 2, 2022
- also apply icon fix to close site alert to relevant stories
@meglake
Copy link

meglake commented Dec 13, 2022

Hi @arcepaul, please update the NCIDS with the svg code and documentation: https://designsystem-dev.cancer.gov/develop/components/site-alert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't functioning or displaying per established requirements DS Development
Projects
None yet
6 participants