Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USA Banner component uses incorrect max width setting #620

Closed
bryanpizzillo opened this issue Oct 14, 2022 · 0 comments · Fixed by #830
Closed

USA Banner component uses incorrect max width setting #620

bryanpizzillo opened this issue Oct 14, 2022 · 0 comments · Fixed by #830
Assignees
@dlescarbeau
Labels
Bug Something isn't functioning or displaying per established requirements DS Development Housekeeping
Milestone
R2 - DS Iteration 14

Comments

@bryanpizzillo
Copy link
Member

Issue description

ESTIMATE TBD

The USA Banner Component (in sass) is currently using the $theme-site-alert-max-width variable. It should be using $theme-banner-max-width.
@bryanpizzillo bryanpizzillo added the Bug Something isn't functioning or displaying per established requirements label Oct 14, 2022
@bennettcc bennettcc added this to the R2 - DS Iteration 14 milestone Mar 24, 2023
dlescarbeau added a commit that referenced this issue Mar 28, 2023
@dlescarbeau
(#620) Changes variable for max-width of banner
33deb9f
@dlescarbeau dlescarbeau mentioned this issue Mar 28, 2023
Merged
arcepaul pushed a commit that referenced this issue Mar 30, 2023
@dlescarbeau @arcepaul
(#620) Changes variable for max-width of banner
cfb8079
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlescarbeau dlescarbeau

Labels
Bug Something isn't functioning or displaying per established requirements DS Development Housekeeping
Projects
None yet
Milestone
R2 - DS Iteration 14
Development

Successfully merging a pull request may close this issue.

(#620) Changes variable for max-width of banner NCIOCPL/ncids
5 participants
@bryanpizzillo @bennettcc @sarinapadilla @meglake @dlescarbeau