Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit nci-banner #653

Closed
bryanpizzillo opened this issue Nov 9, 2022 · 0 comments · Fixed by #1394
Closed

Revisit nci-banner #653

bryanpizzillo opened this issue Nov 9, 2022 · 0 comments · Fixed by #1394
Assignees
@dlescarbeau
Labels
Bug Something isn't functioning or displaying per established requirements DS Development Housekeeping Needs Technical Review Needs review from Architect and Development

Comments

@bryanpizzillo
Copy link
Member

bryanpizzillo commented Nov 9, 2022 •
edited

Issue description

ESTIMATE TBD

The nci-banner partial should be updated to use proper USWDS and make sure we are not redoing items that come from their usa-banner.

This should be backwards compatible so that the banner that is on the website will not look broken.

To follow: NCIOCPL/cgov-digital-platform#4152
@bryanpizzillo bryanpizzillo added Bug Something isn't functioning or displaying per established requirements Housekeeping labels Nov 9, 2022
@sarinapadilla sarinapadilla changed the title Remove defunct _banner partial from nci banner. Revisit nci-banner Aug 22, 2023
@sarinapadilla sarinapadilla mentioned this issue Oct 31, 2023
Closed
@dlescarbeau dlescarbeau self-assigned this Nov 8, 2023
dlescarbeau added a commit that referenced this issue Nov 13, 2023
@dlescarbeau
(#653) extends usa-banner
07e768f 
Closes #653
@dlescarbeau dlescarbeau mentioned this issue Nov 13, 2023
Merged
dlescarbeau added a commit that referenced this issue Nov 13, 2023
@dlescarbeau
(#653) extends usa-banner
08a0222 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 15, 2023
@dlescarbeau
(#653) extends usa-banner
6815a34 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 15, 2023
@dlescarbeau
(#653) extends usa-banner
7769971 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 15, 2023
@dlescarbeau
(#653) extends usa-banner
5f55c3f 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 16, 2023
@dlescarbeau
(#653) extends usa-banner
2d9b71b 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 16, 2023
@dlescarbeau
(#653) extends usa-banner
b936aa7 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 16, 2023
@dlescarbeau
(#653) extends usa-banner
c8d589d 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 16, 2023
@dlescarbeau
(#653) extends usa-banner
089ed52 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 16, 2023
@dlescarbeau
(#653) extends usa-banner
e3841f0 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 17, 2023
@dlescarbeau
(#653) extends usa-banner
dc98eea 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 17, 2023
@dlescarbeau
(#653) extends usa-banner
d10b518 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 17, 2023
@dlescarbeau
(#653) extends usa-banner
6ddd785 
Closes #653
@bennettcc bennettcc added the Needs Technical Review Needs review from Architect and Development label Nov 20, 2023
dlescarbeau added a commit that referenced this issue Nov 21, 2023
@dlescarbeau
(#653) extends usa-banner
21e4931 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 21, 2023
@dlescarbeau
(#653) extends usa-banner
61cfcf0 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 21, 2023
@dlescarbeau
(#653) extends usa-banner
d5fc22d 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 21, 2023
@dlescarbeau
(#653) extends usa-banner
afce8e8 
Closes #653
dlescarbeau added a commit that referenced this issue Nov 21, 2023
@dlescarbeau
(#653) extends usa-banner
4a630a8 
Closes #653
arcepaul pushed a commit that referenced this issue Dec 5, 2023
@dlescarbeau @olitharp-nci
(#653) extends usa-banner
745993e 
Closes #653
@bennettcc bennettcc mentioned this issue Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlescarbeau dlescarbeau

Labels
Bug Something isn't functioning or displaying per established requirements DS Development Housekeeping Needs Technical Review Needs review from Architect and Development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#653) extends usa-banner NCIOCPL/ncids
4 participants
@bryanpizzillo @bennettcc @meglake @dlescarbeau