Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabler: Enable twigjs in ncids-css-testing for storybook #824

Closed
bryanpizzillo opened this issue Mar 21, 2023 · 0 comments · Fixed by #829
Closed

Enabler: Enable twigjs in ncids-css-testing for storybook #824

bryanpizzillo opened this issue Mar 21, 2023 · 0 comments · Fixed by #829
Assignees
@olitharp-nci
Labels
Needs Technical Review Needs review from Architect and Development uswds-native
Milestone
R2 - DS Iteration 14

Comments

@bryanpizzillo
Copy link
Member

Enable twigjs in ncids-css-testing for storybook

ESTIMATE TBD

With importing USWDS native components, we need to be able to setup backstop regressions in order to make sure we do not break USWDS components. The USWDS comes with a number of Storybook stories, however, they use twig for making the HTML. We can implement the same approach and reuse USWDS stories and at the same time remove lots of duplicate copy/paste HTML for our stories. This ticket is to enable twigjs in ncids-css-testing.
@olitharp-nci olitharp-nci self-assigned this Mar 22, 2023
@bennettcc bennettcc added this to the R2 - DS Iteration 14 milestone Mar 24, 2023
olitharp-nci added a commit that referenced this issue Mar 24, 2023
@olitharp-nci
(#824) Enable twig for css testing
142c7d5
olitharp-nci added a commit that referenced this issue Mar 27, 2023
@olitharp-nci
(#824) Enable twig for css testing
640b565
@olitharp-nci olitharp-nci mentioned this issue Mar 27, 2023
Merged
olitharp-nci added a commit that referenced this issue Mar 27, 2023
@olitharp-nci
(#824) Enable twig for css testing
a777d4b
olitharp-nci added a commit that referenced this issue Mar 27, 2023
@olitharp-nci
(#824) Enable twig for css testing
ab4107d
olitharp-nci added a commit that referenced this issue Mar 29, 2023
@olitharp-nci
(#824) Enable twig for css testing
20d641d
olitharp-nci added a commit that referenced this issue Mar 29, 2023
@olitharp-nci
(#824) Enable twig for css testing
cd912c7
olitharp-nci added a commit that referenced this issue Mar 29, 2023
@olitharp-nci
(#824) Enable twig for css testing
26afee5
olitharp-nci added a commit that referenced this issue Mar 29, 2023
@olitharp-nci
(#824) Enable twig for css testing
66885ab
olitharp-nci added a commit that referenced this issue Mar 29, 2023
@olitharp-nci
(#824) Enable twig for css testing
c044d36
olitharp-nci added a commit that referenced this issue Mar 30, 2023
@olitharp-nci
(#824) Enable twig for css testing
e495efc
olitharp-nci added a commit that referenced this issue Mar 31, 2023
@olitharp-nci
(#824) Enable twig for css testing
211b51e
olitharp-nci added a commit that referenced this issue Mar 31, 2023
@olitharp-nci
(#824) Enable twig for css testing
13d29b5
olitharp-nci added a commit that referenced this issue Mar 31, 2023
@olitharp-nci
(#824) Enable twig for css testing
e0d40f5
olitharp-nci added a commit that referenced this issue Mar 31, 2023
@olitharp-nci
(#824) Enable twig for css testing
d54a65a
olitharp-nci added a commit that referenced this issue Mar 31, 2023
@olitharp-nci
(#824) Enable twig for css testing
4f4fe7f
olitharp-nci added a commit that referenced this issue Mar 31, 2023
@olitharp-nci
(#824) Enable twig for css testing
771bf49
olitharp-nci added a commit that referenced this issue Mar 31, 2023
@olitharp-nci
(#824) Enable twig for css testing
7956815
olitharp-nci added a commit that referenced this issue Mar 31, 2023
@olitharp-nci
(#824) Enable twig for css testing
f5e02de
olitharp-nci added a commit that referenced this issue Apr 3, 2023
@olitharp-nci
(#824) Enable twig for css testing
1986901
olitharp-nci added a commit that referenced this issue Apr 3, 2023
@olitharp-nci
(#824) Enable twig for css testing
42c87ba
olitharp-nci added a commit that referenced this issue Apr 3, 2023
@olitharp-nci
(#824) Enable twig for css testing
60521ff
olitharp-nci added a commit that referenced this issue Apr 3, 2023
@olitharp-nci
(#824) Enable twig for css testing
f9f2433
olitharp-nci added a commit that referenced this issue Apr 3, 2023
@olitharp-nci
(#824) Enable twig for css testing
abfbacd
olitharp-nci added a commit that referenced this issue Apr 4, 2023
@olitharp-nci
(#824) Enable twig for css testing
d087816
olitharp-nci added a commit that referenced this issue Apr 4, 2023
@olitharp-nci
(#824) Enable twig for css testing
f622b08
@bennettcc bennettcc added the Needs Technical Review Needs review from Architect and Development label Apr 4, 2023
olitharp-nci added a commit that referenced this issue Apr 4, 2023
@olitharp-nci
(#824) Enable twig for css testing
d20cbb2
bryanpizzillo pushed a commit that referenced this issue Apr 4, 2023
@olitharp-nci @bryanpizzillo
(#824) Enable twig for css testing
dd39af1
@bryanpizzillo bryanpizzillo mentioned this issue Apr 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olitharp-nci olitharp-nci

Labels
Needs Technical Review Needs review from Architect and Development uswds-native
Projects
None yet
Milestone
R2 - DS Iteration 14
Development

Successfully merging a pull request may close this issue.

(#824) Enable twig for css testing NCIOCPL/ncids
3 participants
@bryanpizzillo @bennettcc @olitharp-nci