Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-Page Navigation USWDS Pass Through to NCIDS #888

Closed
6 tasks done
sarinapadilla opened this issue Apr 6, 2023 · 0 comments · Fixed by #902
Closed
6 tasks done

In-Page Navigation USWDS Pass Through to NCIDS #888

sarinapadilla opened this issue Apr 6, 2023 · 0 comments · Fixed by #902
Assignees
@olitharp-nci
Labels
uswds-native
Milestone
R2 - DS Iteration 15

Comments

@sarinapadilla
Copy link

sarinapadilla commented Apr 6, 2023 •
edited by olitharp-nci

This task is to pass the In-Page Navigation USWDS Component through to the NCIDS.

USWDS Component Name

In-Page Navigation

USWDS Component Packages

  • Package usage: @forward "usa-in-page-navigation";

Subtasks

  • Make a folder with the component name under uswds-native
  • Copy USWDS twig and any JSON
  • Make an index.scss for the stories
  • Copy and hack up USWDS stories.js file to use our story format
  • Create scenarios.js by adding a scenario for each story in stories.js
  • Add link to the USWDS documentation on the NCIDS documentation site
@sarinapadilla sarinapadilla added this to the R2 - DS Iteration 15 milestone Apr 6, 2023
@olitharp-nci olitharp-nci self-assigned this Apr 10, 2023
olitharp-nci added a commit that referenced this issue Apr 10, 2023
@olitharp-nci
(#888) Add usa-in-page-navigation to DS
c30636d
olitharp-nci added a commit that referenced this issue Apr 10, 2023
@olitharp-nci
(#888) Add usa-in-page-navigation to DS
1079fc0
@olitharp-nci olitharp-nci mentioned this issue Apr 10, 2023
Merged
olitharp-nci added a commit that referenced this issue Apr 12, 2023
@olitharp-nci
(#888) Add usa-in-page-navigation to DS
7805ec1
olitharp-nci added a commit that referenced this issue Apr 12, 2023
@olitharp-nci
(#888) Add usa-in-page-navigation to DS
5c2e05f
olitharp-nci added a commit that referenced this issue Apr 12, 2023
@olitharp-nci
(#888) Add usa-in-page-navigation to DS
03cc747
olitharp-nci added a commit that referenced this issue Apr 12, 2023
@olitharp-nci
(#888) Add usa-in-page-navigation to DS
e3bf2f2
olitharp-nci added a commit that referenced this issue Apr 12, 2023
@olitharp-nci
(#888) Add usa-in-page-navigation to DS
402217f 
- Added global Storybook decorator to allow uswds component js init on story build
- Added uswds-native js alias to Storybook webpack for cleaner imports & maintainability
- Updated ncids-css-testing README with uswds-native js story instructions
@bennettcc bennettcc added Needs Technical Review Needs review from Architect and Development Needs Product Review Needs review from Product, QA, Design, and IA labels Apr 13, 2023
arcepaul pushed a commit that referenced this issue Apr 13, 2023
@olitharp-nci @arcepaul
(#888) Add usa-in-page-navigation to DS
936a5f6 
- Added global Storybook decorator to allow uswds component js init on story build
- Added uswds-native js alias to Storybook webpack for cleaner imports & maintainability
- Updated ncids-css-testing README with uswds-native js story instructions
@bennettcc bennettcc removed Needs Technical Review Needs review from Architect and Development Needs Product Review Needs review from Product, QA, Design, and IA labels Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olitharp-nci olitharp-nci

Labels
uswds-native
Projects
None yet
Milestone
R2 - DS Iteration 15
Development

Successfully merging a pull request may close this issue.

(#888) Add usa-in-page-navigation to DS NCIOCPL/ncids
3 participants
@bennettcc @sarinapadilla @olitharp-nci