-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change usa-card-group to Make the Vertical Spacing Between Cards the same as usa-section #889
Milestone
Comments
From a technology standpoint, this should be modifying the |
dlescarbeau
added a commit
that referenced
this issue
Apr 10, 2023
dlescarbeau
added a commit
that referenced
this issue
Apr 10, 2023
dlescarbeau
added a commit
that referenced
this issue
Apr 10, 2023
dlescarbeau
added a commit
that referenced
this issue
Apr 10, 2023
bennettcc
added
the
Needs Technical Review
Needs review from Architect and Development
label
Apr 11, 2023
dlescarbeau
added a commit
that referenced
this issue
Apr 11, 2023
dlescarbeau
added a commit
that referenced
this issue
Apr 11, 2023
dlescarbeau
added a commit
that referenced
this issue
Apr 11, 2023
dlescarbeau
added a commit
that referenced
this issue
Apr 12, 2023
dlescarbeau
added a commit
that referenced
this issue
Apr 12, 2023
bennettcc
removed
the
Needs Technical Review
Needs review from Architect and Development
label
Apr 13, 2023
arcepaul
pushed a commit
that referenced
this issue
Apr 14, 2023
arcepaul
pushed a commit
that referenced
this issue
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Change Request Description
This change request is to adjust the vertical spacing between grouped cards (the
nci-card-group element
, as well as any defined classes in that partial. There is some alternate group element for the 2 Guide Card with Image & Description layout) so that when the cards stack vertically, the space between them are the same as the space used by usa-section. This change will impact 3 Feature Card Row, 2 Guide Card Row - Guide Card with Image and Description, and 3 Guide Card Row - Default Guide CardWhat's the expected change?
What's the current functionality?
What's the updated acceptance criteria?
Additional details / screenshot
The text was updated successfully, but these errors were encountered: