Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change usa-card-group to Make the Vertical Spacing Between Cards the same as usa-section #889

Closed
andyvanavery opened this issue Apr 6, 2023 · 1 comment · Fixed by #899
Assignees

Comments

@andyvanavery
Copy link

andyvanavery commented Apr 6, 2023

Change Request Description

This change request is to adjust the vertical spacing between grouped cards (the nci-card-group element, as well as any defined classes in that partial. There is some alternate group element for the 2 Guide Card with Image & Description layout) so that when the cards stack vertically, the space between them are the same as the space used by usa-section. This change will impact 3 Feature Card Row, 2 Guide Card Row - Guide Card with Image and Description, and 3 Guide Card Row - Default Guide Card

What's the expected change?

  • Vertical space between cards in the vertically stacked orientation (640px <= breakpoint < 880px) will be 32px (equal to usa-section spacing of 16px on bottom of one section + 16px on top of next section)
  • Vertical space between cards in the vertically stacked orientation (breakpoint < 640px) will be 24px (equal to usa-section spacing of 12px on bottom of one section + 12px on top of next section)
  • Vertical space between usa-sections does not change (remains 16px at 640px-880px and 12px below 640px)

What's the current functionality?

  • Vertical space between cards in the vertically stacked orientation (640px <= breakpoint < 880px) is 24px
  • Vertical space between cards in the vertically stacked orientation (breakpoint < 640px) is 12px
  • Vertical space between usa-sections is 16px at 640px-880px and 12px below 640px

What's the updated acceptance criteria?

Scenario: A user views a page with three (3) Feature Cards in a Feature Card Row in the vertically stacked orientation at the Tablet breakpoint
Given a user is viewing a landing page with three (3) Feature Cards
  And the viewed breakpoint is at least 640px and is less than 880px
Then the user will be able to view the three (3) Feature Cards
  And the Feature Cards will be stacked in the vertical orientation
  And the vertical space between the Feature Cards will be 32px
  And the vertical space surrounding the usa-section holding the three (3) Feature Cards will remain the same (16px)
Scenario: A user views a page with three (3) Feature Cards in a Feature Card Row in the vertically stacked orientation at the Mobile Large or Mobile breakpoint
Given a user is viewing a landing page with three (3) Feature Cards
  And the viewed breakpoint is less than 640px
Then the user will be able to view the three (3) Feature Cards
  And the Feature Cards will be stacked in the vertical orientation
  And the vertical space between the Feature Cards will be 24px
  And the vertical space surrounding the usa-section holding the three (3) Feature Cards will remain the same (12px)

Additional details / screenshot

  • 664px Breakpoint: Space between vertically stacked cards is currently 24px
    image
  • 664px Breakpoint: Padding added to the top and bottom of the usa-section is 16px
    image
  • 579px Breakpoint: Space between vertically stacked cards is currently 12px
    image
  • 579px Breakpoint: Padding added to the top and bottom of the usa-section is 12px
    image
@bryanpizzillo
Copy link
Member

From a technology standpoint, this should be modifying the nci-card-group element, as well as any defined classes in that partial. (There is some alternate group element for the 2 Guide Card with Image & Description layout.)

@bennettcc bennettcc added the Needs Technical Review Needs review from Architect and Development label Apr 11, 2023
@bennettcc bennettcc removed the Needs Technical Review Needs review from Architect and Development label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants