(#937) NCIDS for All setup #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viewing Information |
olitharp-nci
force-pushed
the
ticket/ncids-for-all-setup
branch
3 times, most recently
from
5253c1b
to
b8ecc71
Compare
olitharp-nci
force-pushed
the
ticket/ncids-for-all-setup
branch
4 times, most recently
from
35985ed
to
3d34668
Compare
olitharp-nci
force-pushed
the
ticket/ncids-for-all-setup
branch
from
3d34668
to
51bfc9d
Compare
bennettcc
requested review from
arcepaul,
dlescarbeau,
dev-rana-publicis and
karlikpj
karlikpj
approved these changes
Jul 20, 2023
dev-rana-publicis
approved these changes
Jul 20, 2023
|
This was straightforward and easy to follow. Much of the specific detail we needed was found in the (in progress?) example site referenced here. If anything, additional comments to be made once that is finalized. |
arcepaul
force-pushed
the
ticket/ncids-for-all-setup
branch
from
51bfc9d
to
88ecf49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #937
Closes #940