-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1164) Setting up gatsby component templates #1234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcepaul
force-pushed
the
ticket/1164-component-template
branch
11 times, most recently
from
September 20, 2023 06:20
182361a
to
95717a1
Compare
arcepaul
force-pushed
the
ticket/1164-component-template
branch
9 times, most recently
from
September 28, 2023 04:23
cd1a424
to
85bed47
Compare
arcepaul
force-pushed
the
ticket/1164-component-template
branch
from
September 29, 2023 20:22
85bed47
to
be877ce
Compare
arcepaul
force-pushed
the
ticket/1164-component-template
branch
3 times, most recently
from
October 3, 2023 14:11
77c03d7
to
0628c27
Compare
bennettcc
approved these changes
Oct 3, 2023
Approved by IAs + Product on 10/3 |
LGTM but I'm not really sure what I'd have for feedback anyhow |
dlescarbeau
approved these changes
Oct 3, 2023
karlikpj
approved these changes
Oct 3, 2023
arcepaul
force-pushed
the
ticket/1164-component-template
branch
from
October 3, 2023 20:59
0628c27
to
e61d599
Compare
Closes #1164 - lint fix - support for modifications fix for image links? modifications support basic schema template_type change browser title for all the things lint fixes autocomplete reversion PR technical fixes
Closes #1174 - Added content for guide card component page Guide cards updates table guide card edits gc image pathing figma link update template_type guide-card guide card updates guide card overview updates Link Button on guide card overview guiide card links
Closes #1170 - updated content for CTA strip CTA strip updates table cta strip lint fix cta-strip fixes figma link update template_type cta cta updates CTA overview updates cta-strip links
Closes #1168 - updated content for button component page on doc site Button updates template_type button
arcepaul
force-pushed
the
ticket/1164-component-template
branch
from
October 3, 2023 22:16
e61d599
to
2f964ca
Compare
olitharp-nci
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1164 .
Closes #1174 .
Closes #1170 .
Closes #1168 .
Testing links