Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1164) Setting up gatsby component templates #1234

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

arcepaul
Copy link
Contributor

@arcepaul arcepaul commented Sep 13, 2023

Closes #1164 .
Closes #1174 .
Closes #1170 .
Closes #1168 .

Testing links

@arcepaul arcepaul force-pushed the ticket/1164-component-template branch 11 times, most recently from 182361a to 95717a1 Compare September 20, 2023 06:20
@arcepaul arcepaul force-pushed the ticket/1164-component-template branch 9 times, most recently from cd1a424 to 85bed47 Compare September 28, 2023 04:23
@olitharp-nci olitharp-nci marked this pull request as draft September 28, 2023 21:06
@arcepaul arcepaul force-pushed the ticket/1164-component-template branch from 85bed47 to be877ce Compare September 29, 2023 20:22
@olitharp-nci olitharp-nci marked this pull request as ready for review October 2, 2023 14:31
@arcepaul arcepaul force-pushed the ticket/1164-component-template branch 3 times, most recently from 77c03d7 to 0628c27 Compare October 3, 2023 14:11
@bennettcc bennettcc self-requested a review October 3, 2023 15:01
@bennettcc
Copy link

Approved by IAs + Product on 10/3

@dlescarbeau
Copy link
Collaborator

LGTM but I'm not really sure what I'd have for feedback anyhow

@arcepaul arcepaul force-pushed the ticket/1164-component-template branch from 0628c27 to e61d599 Compare October 3, 2023 20:59
Arce, Paul (NIH/NCI) [C] added 4 commits October 3, 2023 16:16
Closes #1164

- lint fix
- support for modifications

fix for image links?

modifications support

basic schema

template_type change

browser title for all the things

lint fixes

autocomplete reversion

PR technical fixes
Closes #1174

- Added content for guide card component page

Guide cards updates table

guide card edits

gc image pathing

figma link update

template_type guide-card

guide card updates

guide card overview updates

Link Button on guide card overview

guiide card links
Closes #1170

- updated content for CTA strip

CTA strip updates table

cta strip lint fix

cta-strip fixes

figma link update

template_type cta

cta updates

CTA overview updates

cta-strip links
Closes #1168

- updated content for button component page on doc site

Button updates

template_type button
@arcepaul arcepaul force-pushed the ticket/1164-component-template branch from e61d599 to 2f964ca Compare October 3, 2023 22:16
@olitharp-nci olitharp-nci merged commit db9dc74 into develop Oct 3, 2023
3 checks passed
@olitharp-nci olitharp-nci deleted the ticket/1164-component-template branch October 4, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants