(#1203) Typography Font Size Family #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viewing Information |
karlikpj
force-pushed
the
ticket/1203-typography-fontsize-family
branch
11 times, most recently
from
c6bba2f
to
59429ae
Compare
karlikpj
force-pushed
the
ticket/1203-typography-fontsize-family
branch
2 times, most recently
from
24d0d02
to
817e561
Compare
bennettcc
approved these changes
Sep 29, 2023
olitharp-nci
requested changes
Oct 3, 2023
There was a problem hiding this comment.
what are we doing about the other utility classes from this page?
https://designsystem.digital.gov/utilities/font-size-and-family/
the sizes for ncids will not match uswds
There was a problem hiding this comment.
adding - but without actual pixel sizes ? or we can inspect the table and adjust/round accordingly
karlikpj
force-pushed
the
ticket/1203-typography-fontsize-family
branch
8 times, most recently
from
3d6f15b
to
dcf81a7
Compare
karlikpj
force-pushed
the
ticket/1203-typography-fontsize-family
branch
from
dcf81a7
to
ec50735
Compare
|
This was re-reviewed by @andyvanavery31 on 10/6 - passes his review and this is ready to be merged from products perspective @karlikpj @olitharp-nci |
olitharp-nci
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1203