Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#563) Site Alert Auto ID #1399

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

karlikpj
Copy link
Contributor

Closes #563

Copy link

Viewing Information

@karlikpj karlikpj force-pushed the ticket/563-automate-site-alert-id branch 2 times, most recently from 3e7de34 to dda24c4 Compare November 17, 2023 18:40
@karlikpj karlikpj marked this pull request as ready for review November 17, 2023 21:16
@karlikpj karlikpj force-pushed the ticket/563-automate-site-alert-id branch 2 times, most recently from 92357e2 to 4294e64 Compare November 20, 2023 18:48
Copy link
Contributor

@olitharp-nci olitharp-nci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the example site is throwing some errors on the site alert collapse functionality

Uncaught DOMException: Failed to execute 'querySelector' on 'Element': '#' is not a valid selector.
    at n.toggleCollapseA11y

@karlikpj karlikpj force-pushed the ticket/563-automate-site-alert-id branch 2 times, most recently from 653cb4c to fc324e3 Compare November 21, 2023 14:36
@karlikpj karlikpj force-pushed the ticket/563-automate-site-alert-id branch from fc324e3 to 886247c Compare November 28, 2023 13:27
@arcepaul arcepaul merged commit 5f92bc2 into develop Nov 29, 2023
3 checks passed
@arcepaul arcepaul deleted the ticket/563-automate-site-alert-id branch November 29, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate usa-site-alert component id
3 participants