Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1388) Update overview image on Footer Page #1490

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

karlikpj
Copy link
Contributor

Closes #1388

Copy link

@karlikpj karlikpj marked this pull request as ready for review January 23, 2024 21:40
Copy link

@dcvijanovic1k dcvijanovic1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Tested FF/Chrome/Safari

Copy link

@andyvanavery31 andyvanavery31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Updates table with a line indicating the update with the change from the former Twitter logo to X.

@karlikpj karlikpj force-pushed the ticket/1388-update-overview-image-footer branch from be4f8a0 to b6d3784 Compare January 24, 2024 20:32
@sarinapadilla sarinapadilla requested a review from a team January 25, 2024 16:01
Copy link

@sarinapadilla sarinapadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good visually and Updates table changes have been made!

Copy link

@andyvanavery31 andyvanavery31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes my review!

@karlikpj karlikpj force-pushed the ticket/1388-update-overview-image-footer branch from b6d3784 to 5c811fd Compare January 25, 2024 19:24
@arcepaul
Copy link
Contributor

@dcvijanovic1k The overview image has a gray background that does not match the gray in the overview area. Can you provide a new overview image with transparent bg? The padding around the callouts can also be reduced as the overview area adds padding which will help increase the size of the image.

Screenshot 2024-01-26 at 9 13 28 AM

@dcvijanovic1k
Copy link

@arcepaul - here's the updated image you need. Please let me know if there's anything else!
footer_overview-v2

@arcepaul arcepaul force-pushed the ticket/1388-update-overview-image-footer branch from 5c811fd to d508610 Compare January 26, 2024 16:37
@arcepaul arcepaul merged commit 4740b21 into develop Jan 26, 2024
3 checks passed
@arcepaul arcepaul deleted the ticket/1388-update-overview-image-footer branch January 26, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Twitter Icon on the Documentation Site Footer Overview Image
5 participants