-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1388) Update overview image on Footer Page #1490
Conversation
Viewing Information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Tested FF/Chrome/Safari
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the Updates table with a line indicating the update with the change from the former Twitter logo to X.
be4f8a0
to
b6d3784
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good visually and Updates table changes have been made!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes my review!
b6d3784
to
5c811fd
Compare
@dcvijanovic1k The overview image has a gray background that does not match the gray in the overview area. Can you provide a new overview image with transparent bg? The padding around the callouts can also be reduced as the overview area adds padding which will help increase the size of the image. |
@arcepaul - here's the updated image you need. Please let me know if there's anything else! |
5c811fd
to
d508610
Compare
Closes #1388