(#1589) Updates usa-list twig and styles, storybook structure #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viewing Information |
dlescarbeau
force-pushed
the
ticket/1589-usa-list-storybook-update
branch
3 times, most recently
from
b946b3b
to
7e2275a
Compare
dlescarbeau
force-pushed
the
ticket/1589-usa-list-storybook-update
branch
2 times, most recently
from
06ea914
to
8060754
Compare
karlikpj
approved these changes
Apr 10, 2024
olitharp-nci
requested changes
Apr 15, 2024
| {% endif %} | ||
| {% set classes = class ~ class1 ~ class2 %} | ||
|
|
||
| {% if ordered %} |
There was a problem hiding this comment.
clean up filter and indents:
{% set class = "usa-list" %}
{% if "twoColumn" in variant %}
{% set class = class + " usa-list--two-column" %}
{% endif %}
{% if "unstyled" in variant %}
{% set class = class + " usa-list--unstyled" %}
{% endif %}
{% if ordered %}
<ol class="{{ class }}">
{% else %}
<ul class="{{ class }}">
{% endif %}
{% for item in items %}
<li>{{ item }}</li>
{% endfor %}
{% if ordered %}
</ol>
{% else %}
</ul>
{% endif %}|
|
||
| const Template = (args) => Component(args); | ||
|
|
||
| export const USWDSList = () => <TestCase css={css} html={Template.bind({})()} />; |
There was a problem hiding this comment.
We don't need a USWDS test case. That's really only for USWDS HTML with NCIDS JS. Remove this and the scenarios.
| import css from './index.scss'; | ||
|
|
||
| export default { | ||
| title: 'Components/usa-list/Default', |
| import css from './index.scss'; | ||
|
|
||
| export default { | ||
| title: 'Components/usa-list/Modifiers', |
dlescarbeau
force-pushed
the
ticket/1589-usa-list-storybook-update
branch
5 times, most recently
from
04d1cce
to
0496e32
Compare
dlescarbeau
force-pushed
the
ticket/1589-usa-list-storybook-update
branch
from
0496e32
to
c5d1a85
Compare
olitharp-nci
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1589