-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1583) CTA Strip Storybook Update #1623
Conversation
Viewing Information |
e10f300
to
3f4325a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please change the symbol in front of Test Cases to be the folder icon, not the 2x2 grid? Also, can you please add a space between "TestCases" so that it reads "Test Cases"
2 questions, not change requests: 1. does the mobile breakpoint need left and right padding on the <div class="grid-container"? In use, we have 16px of padding inside the <div class="nci-hero__nci-cta-strip-container">
, but I'm not sure if this just doesn't show up because it's not in that container.
- Should the images for mobile large and tablet be considered redundant? The buttons are the same width, just the width of the container changes with the breakpoint. If they are redundant, lets remove the one size from each (Default, Default Long, Default Spanish)
8b61f9b
to
99e441c
Compare
Q1 - we dont show any padding in the docsite/example code so Id opt not to do that in the regression images.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
9af7998
to
f4a514a
Compare
.../ncids-css-testing/stories/components/nci-cta-strip/nci-cta-strip.testcases.long.stories.jsx
Outdated
Show resolved
Hide resolved
testing/ncids-css-testing/stories/components/nci-cta-strip/nci-cta-strip.scenarios.js
Outdated
Show resolved
Hide resolved
0d5077d
to
33f2601
Compare
33f2601
to
6fce3b5
Compare
Closes #1583