(#547) Hero and CTA strip #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viewing Information |
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
6 times, most recently
from
92ebd62
to
2d9e6fb
Compare
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
2 times, most recently
from
01aa1e9
to
5bc1bd3
Compare
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
from
5bc1bd3
to
e2c11f7
Compare
olitharp-nci
requested changes
Feb 28, 2023
packages/ncids-css/scss/components/nci-hero-cta/_nci-hero-cta.scss
Outdated
Show resolved
Hide resolved
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
3 times, most recently
from
c18a1f0
to
983b57f
Compare
dlescarbeau
reviewed
Mar 1, 2023
packages/ncids-css/scss/components/nci-hero-cta/internal/_nci-hero-cta.scss
Outdated
Show resolved
Hide resolved
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
2 times, most recently
from
f7944dc
to
a561899
Compare
arcepaul
reviewed
Mar 2, 2023
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
from
a561899
to
bfa9090
Compare
arcepaul
reviewed
Mar 2, 2023
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
2 times, most recently
from
c40ca31
to
e83080e
Compare
arcepaul
approved these changes
Mar 3, 2023
|
Approved by Product. Waiting on approval by client. |
|
Can you please add CTA variant examples on the hero example page? |
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
2 times, most recently
from
4ce7963
to
400ef98
Compare
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
from
400ef98
to
e46ab32
Compare
olitharp-nci
requested changes
Mar 6, 2023
packages/ncids-css/scss/components/nci-hero-cta/internal/_nci-hero-cta.scss
Outdated
Show resolved
Hide resolved
arcepaul
force-pushed
the
ticket/547-hero-cta
branch
from
e46ab32
to
b543610
Compare
karlikpj
force-pushed
the
ticket/547-hero-cta
branch
2 times, most recently
from
25d263f
to
681878e
Compare
arcepaul
reviewed
Mar 7, 2023
arcepaul
force-pushed
the
ticket/547-hero-cta
branch
from
681878e
to
81bfa0e
Compare
bennettcc
approved these changes
Mar 8, 2023
|
This was approved yesterday by Fed clients - approving on behalf of product |
arcepaul
force-pushed
the
ticket/547-hero-cta
branch
from
81bfa0e
to
0eee567
Compare
dlescarbeau
force-pushed
the
ticket/547-hero-cta
branch
3 times, most recently
from
a25a349
to
9b33738
Compare
arcepaul
force-pushed
the
ticket/547-hero-cta
branch
3 times, most recently
from
8a6ecf7
to
e2a1f31
Compare
olitharp-nci
requested changes
Mar 9, 2023
testing/ncids-js-testing/public/example-pages/nci-cta-strip.html
Outdated
Show resolved
Hide resolved
arcepaul
force-pushed
the
ticket/547-hero-cta
branch
from
e2a1f31
to
53d2332
Compare
olitharp-nci
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #547