Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#802) Fix ncids body styles #803

Merged
merged 1 commit into from
Mar 9, 2023
Merged

(#802) Fix ncids body styles #803

merged 1 commit into from
Mar 9, 2023

Conversation

olitharp-nci
Copy link
Contributor

@olitharp-nci olitharp-nci commented Mar 8, 2023 •
edited

@olitharp-nci olitharp-nci requested a review from a team as a code owner March 8, 2023 21:40
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Viewing Information

@olitharp-nci
Copy link
Contributor Author

olitharp-nci commented Mar 8, 2023 •
edited

Cliffsnotes change log

skipnav

failed_diff_ncids_usa-skipnav_English_unfocused_0_document_0_mobile

failed_diff_ncids_usa-skipnav_English_focused_0_document_0_mobile

section

failed_diff_ncids_usa-section_Light_Example_0_document_0_mobile

failed_diff_ncids_usa-section_Example_0_document_0_mobile

list

failed_diff_ncids_usa-list_unstyled_0_document_0_mobile

failed_diff_ncids_usa-list_default_0_document_0_mobile

hero

failed_diff_ncids_nci-hero_default_with-button_0_document_0_mobile

failed_diff_ncids_nci-hero_default_0_document_0_mobile

guide card

failed_diff_ncids_nci-guide-card-with-image-and-description_guide-card-row_0_document_0_mobile

  • section headers include @include u-text($theme-color-base-ink);

card

failed_diff_ncids_nci-card_card-in-text-right_0_document_0_mobile

  • description text sets @include u-text($theme-color-base-ink);

failed_diff_ncids_nci-card_card-in-text-left_0_document_0_mobile

  • description text sets @include u-text($theme-color-base-ink);

header search

failed_diff_ncids_nci-header_nci-extended_search_clear_0_document_1_mobile

  • input[type=search] sets color: color('ink');

autocomplete

failed_diff_ncids_nci-autocomplete_suggestions_0_document_0_mobile

  • input[type=search] sets color: color('ink');

failed_diff_ncids_nci-autocomplete_option-highlighted_0_document_0_mobile

  • input[type=search] sets color: color('ink');

failed_diff_ncids_nci-autocomplete_matching-highlight-disabled_0_document_0_mobile

  • input[type=search] sets color: color('ink');

failed_diff_ncids_nci-autocomplete_input-below-min-message_0_document_0_mobile

  • input[type=search] sets color: color('ink');

sarinapadilla
sarinapadilla approved these changes Mar 9, 2023
View reviewed changes
Copy link

@sarinapadilla sarinapadilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on behalf of product!

@olitharp-nci
Copy link
Contributor Author

Cliffsnotes changelog part two

nci-hero with cta strip

failed_diff_ncids_nci-hero_with-cta_0_document_0_mobile
failed_diff_ncids_nci-hero_with-cta-long_0_document_0_mobile
failed_diff_ncids_nci-hero_with-cta-spanish_0_document_0_mobile

@bryanpizzillo bryanpizzillo merged commit 28a3386 into develop Mar 9, 2023
@bryanpizzillo bryanpizzillo deleted the ticket/802-body-styles branch March 9, 2023 21:33
@sarinapadilla sarinapadilla mentioned this pull request Mar 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarinapadilla sarinapadilla sarinapadilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use USWDS body styles
3 participants
@olitharp-nci @sarinapadilla @bryanpizzillo