(#849) File Input Pass Through #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viewing Information |
karlikpj
force-pushed
the
ticket/849-file-input
branch
5 times, most recently
from
00e8aee
to
e4aea5f
Compare
karlikpj
force-pushed
the
ticket/849-file-input
branch
4 times, most recently
from
d9bb3d8
to
9dc520e
Compare
bennettcc
approved these changes
Apr 26, 2023
|
Approved by product on 4/26 |
|
This is currently having A11Y contrast issues. This is due to the font size/background color combination that is produced by our customized tokens. Our selected colors for links do not pass for small text contrast unless on white. Attached is an options which can pass by setting the fonts to 16px / the background white and using the blue for the border. |
olitharp-nci
added
On Hold
|
on hold for color correction |
karlikpj
force-pushed
the
ticket/849-file-input
branch
from
9dc520e
to
be2f880
Compare
bennettcc
removed
Needs Technical Review
karlikpj
force-pushed
the
ticket/849-file-input
branch
2 times, most recently
from
1415b54
to
b3909e0
Compare
bennettcc
requested review from
dlescarbeau,
arcepaul,
olitharp-nci and
bennettcc
olitharp-nci
requested changes
Jul 21, 2023
There was a problem hiding this comment.
Need a scenario for upload state
Currently looks like:
Need to hear from design about your suggestion #951 (comment)
|
@olitharp-nci @karlikpj I would be ok with the suggestion in the above comment. Let me know if you need more details to implement. Thanks! |
karlikpj
force-pushed
the
ticket/849-file-input
branch
4 times, most recently
from
765243a
to
8b9280b
Compare
|
|
karlikpj
force-pushed
the
ticket/849-file-input
branch
2 times, most recently
from
b052d9d
to
e3d3fcf
Compare
olitharp-nci
approved these changes
Aug 2, 2023
karlikpj
force-pushed
the
ticket/849-file-input
branch
3 times, most recently
from
f4116f2
to
69f6439
Compare
olitharp-nci
force-pushed
the
ticket/849-file-input
branch
from
69f6439
to
65b86be
Compare
olitharp-nci
requested review from
olitharp-nci
and removed request for
olitharp-nci
olitharp-nci
force-pushed
the
ticket/849-file-input
branch
from
65b86be
to
a567c45
Compare
sarinapadilla
approved these changes
Aug 11, 2023
olitharp-nci
force-pushed
the
ticket/849-file-input
branch
from
a567c45
to
4aff528
Compare
dlescarbeau
approved these changes
Aug 11, 2023
olitharp-nci
force-pushed
the
ticket/849-file-input
branch
from
0021aee
to
e4b3ae6
Compare
olitharp-nci
force-pushed
the
ticket/849-file-input
branch
from
3cda2b3
to
bfe3a1a
Compare
arcepaul
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #849