Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#891) Add usa-search to ncids #959

Merged
merged 1 commit into from
Jun 28, 2023
Merged

(#891) Add usa-search to ncids #959

merged 1 commit into from
Jun 28, 2023

Conversation

olitharp-nci
Copy link
Contributor

Closes #891

@olitharp-nci olitharp-nci requested a review from a team as a code owner April 28, 2023 16:51
@olitharp-nci olitharp-nci added Needs Technical Review Needs review from Architect and Development Needs Product Review Needs review from Product, QA, Design, and IA labels Apr 28, 2023
@github-actions
Copy link

Viewing Information

@olitharp-nci olitharp-nci force-pushed the ticket/891-uswds-search branch 2 times, most recently from 2dbc551 to 6e8bbd6 Compare April 28, 2023 16:53
@bennettcc bennettcc removed Needs Technical Review Needs review from Architect and Development Needs Product Review Needs review from Product, QA, Design, and IA labels May 1, 2023
@olitharp-nci olitharp-nci added Needs Technical Review Needs review from Architect and Development Needs Product Review Needs review from Product, QA, Design, and IA and removed Needs Technical Review Needs review from Architect and Development labels May 9, 2023
@andyvanavery
Copy link

Reviewed and approved by Andy Van Avery on 14JUN2023. Review needed from Design for checkmark.
NOTE: The Clear button ('x') does not appear on the search bar in Firefox. This is consistent with USWDS, but may be a future update we can make to work better.

@arcepaul arcepaul merged commit 751d669 into develop Jun 28, 2023
3 checks passed
@arcepaul arcepaul deleted the ticket/891-uswds-search branch June 28, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlescarbeau dlescarbeau dlescarbeau approved these changes

@arcepaul arcepaul arcepaul approved these changes

@karlikpj karlikpj karlikpj approved these changes

@monika-jaeger monika-jaeger monika-jaeger approved these changes

Assignees
No one assigned
Labels
Needs Product Review Needs review from Product, QA, Design, and IA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search USWDS Pass Through to NCIDS
7 participants
@olitharp-nci @andyvanavery @dlescarbeau @arcepaul @karlikpj @monika-jaeger @bennettcc