-
Notifications
You must be signed in to change notification settings - Fork 606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add version strings where applicable in the correct field (and make sure they match the status fields).
I have corrected the Version column for the BCT products for which a fix is available (Liber and e-Invoice). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution.
Please sort the product names according to alphabet.
You also have unrelated changes in here which affect Schneider Electric. Therefore, please update your PR.
@bct-lvb: Thank you for the contribution. Unfortunately, you still have unrelated changes here which affect the Schneider Electric entries. There are 2 ways to resolve them:
Please let me know if you need additional advise. |
I've tried to merge the current version from the main branch into this PR, as you suggested, so all contents are the same now, with the addition of BCT products. Have I done this right? |
By the way, I don't even know how the Schneider Electric entries got affected in the first place. I've never touched them. I've used GitHub's functionality to edit the Readme.md file and only added the BCT entries, but it appears those changes got already in the first commit somehow. |
Unfortunately, no (or you did, but the result is not looking as expected). But that is my fault - I didn't explain what I meant by "Merge the current version into your existing PR." I was thinking of syncing the fork/branch. As it might be quite complex to clean this up via the web-UI: Do you mind if we close this PR and you create a new one? The safest way to do that would be to fork the repo and edit the file in the fork and then provide a new Pull request. Feel free to mention me (@tschmidtb51) in the PR so that I get a notification to look at it. |
My apologies for the inconvenience. Let's indeed close this PR and start a new one. Who would've thought that using GitHub's web-UI functionality would be so hard to use? ;) I'll just do it the old-fashioned way with my trusted IDE for the new PR. Thanks for your help so far and I'll tag you in the new PR. |
Added BCT products (Corsa, Liber, BCE, IDT, e-Invoice, iGEN) to Readme.md.