This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
implemented updatedBy field in concept, and the functionality to sear… #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarvelle
reviewed
May 27, 2020
| @@ -205,6 +216,7 @@ trait ConverterService { | |||
| source = concept.source, | |||
| created = clock.now(), | |||
| updated = clock.now(), | |||
| updatedBy = Seq(userInfo.id), | |||
There was a problem hiding this comment.
Riskerer du ikkje å overskrive lista med brukerider her?
There was a problem hiding this comment.
I det tilfelle så er det slik at conceptet finnes ikke med denne id'en, mens det finnes en rad med samme id i databasen. I det tilfelle lager vi et helt nytt concept så ingenting blir overskrivet siden det ikke er noe fra før av
There was a problem hiding this comment.
Ok. Då skal eg ikkje krangle på det.
jnatten
reviewed
May 27, 2020
| @@ -56,6 +56,7 @@ trait DraftConceptIndexService { | |||
| dateField("lastUpdated"), | |||
| keywordField("status.current"), | |||
| keywordField("status.other"), | |||
| keywordField("users"), | |||
There was a problem hiding this comment.
Syns at users er et lite beskrivende navn
There was a problem hiding this comment.
@N4G1 kan du ikkje lage en ny pr der du kaller det updatedBy? Søket kan fremdeles være users som det er i search-api.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ch by users
https://github.com/NDLANO/Issues/issues/2107