Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend list of used repositories including dependencies #110

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

otacke
Copy link

@otacke otacke commented Nov 3, 2022

No description provided.

@otacke otacke requested a review from janlindso November 3, 2022 12:34
@janlindso janlindso merged commit 7291dd1 into master Nov 3, 2022
@otacke
Copy link
Author

otacke commented Nov 3, 2022

@janlindso Please not that building a complete H5P file from that list will still fail, because the repositories of the "NDLA show-when widget" and the "original show-when widget" bear the same name, but both are required.

The solution here is to not use the NDLA fork at all, because no code was changed. All dependencies can be moved to the original version, and the fork can then be removed.

@otacke otacke deleted the amend_build_info_repos branch August 27, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants