update comment

NE-SmallTown · Apr 28, 2020 · 7c8506a · 7c8506a
1 parent f3db2f5
commit 7c8506a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 2 deletions.
diff --git a/packages/react-dom/src/events/__tests__/SimpleEventPlugin-test.internal.js b/packages/react-dom/src/events/__tests__/SimpleEventPlugin-test.internal.js
@@ -318,7 +318,7 @@ describe('SimpleEventPlugin', function() {
       Scheduler.unstable_flushAll();
       expect(ops).toEqual([]);
     });
-
+    // HEAVEN deterministic
     it('end result of many interactive updates is deterministic', () => {
       container = document.createElement('div');
       const root = ReactDOM.unstable_createRoot(container);

diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.js b/packages/react-reconciler/src/ReactFiberCommitWork.js
@@ -395,6 +395,7 @@ export function commitPassiveHookEffects(finishedWork: Fiber): void {
       case FunctionComponent:
       case ForwardRef:
       case SimpleMemoComponent: {
+        // 先执行所有的 unmount，再执行所有的 mount
         commitHookEffectList(UnmountPassive, NoHookEffect, finishedWork);
         commitHookEffectList(NoHookEffect, MountPassive, finishedWork);
         break;

diff --git a/packages/react-reconciler/src/ReactUpdateQueue.js b/packages/react-reconciler/src/ReactUpdateQueue.js
@@ -485,7 +485,7 @@ export function processUpdateQueue<State>(
       // we have no way of detecting the difference between a committed and suspended
       // update here.
       markRenderEventTimeAndConfig(updateExpirationTime, update.suspenseConfig);
-
+      // HEAVEN setState 第一个参数如果是 func，那么什么时候去调？
       // Process it and compute a new result.
       resultState = getStateFromUpdate(
         workInProgress,

diff --git a/packages/react-reconciler/src/__tests__/ReactIncrementalUpdates-test.internal.js b/packages/react-reconciler/src/__tests__/ReactIncrementalUpdates-test.internal.js
@@ -181,6 +181,7 @@ describe('ReactIncrementalUpdates', () => {
     // Now flush the remaining work. Even though e and f were already processed,
     // they should be processed again, to ensure that the terminal state
     // is deterministic.
+    // HEAVEN deterministic
     expect(Scheduler).toFlushAndYield([
       'a',
       'b',