Rework splash screen #224
Open
Rework splash screen #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused tat-round.png and tat-transparent-white.png - Remove explicit default configuration in flutter_native_splash section of pubspec.yaml - Add splash-android_12.png and its dark variant. The image is 1152x1152, and the icon fits within a circle 768 pixels in diameter.
The branding image is based on `NPC text.svg` found in the club Drive. The text itself is half of the image size. The colors have contrast ratio of about 2 to the background.
Run `dart run flutter_native_splash:create`.
rileychh
added
type: enhancement
ntut-xuan
requested changes
Feb 28, 2024
There was a problem hiding this comment.
似乎動到了 indent 導致檔案出現很大量的 changes，請 revert。
There was a problem hiding this comment.
這是新版 dart run flutter_native_splash:create 造成的縮排變動。日後重新產生仍會影響縮排，我建議在此遷移到新版的行為，避免日後再次遭到變動。
| @@ -132,19 +132,22 @@ flutter_icons: | |||
| image_path: "assets/images/tat.png" | |||
|
|
|||
| flutter_native_splash: | |||
| color: "#FFFFFF" | |||
| color: "#ffffff" | |||
There was a problem hiding this comment.
#ffffff 與 #FFFFFF 會對功能造成差別嗎？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces splash screens across all platforms. NPC branding has been added to the bottom of the screens. Details about the changes can be found in the commit messages.
Implementation
splash-android_12.pngand its dark variant.branding.pngand its dark variant.Testing Instructions
Launch the app on each platform in both light mode and dark mode to check that the images are correctly displayed.
Additional Notes
SplashScreenAPI in Android 12, the text "我的北科生活 TAT" has been removed from the splash screen.