Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External configuration #2

Closed
3 tasks done
TimPietrusky opened this issue Apr 21, 2019 · 1 comment
Closed
3 tasks done

External configuration #2

TimPietrusky opened this issue Apr 21, 2019 · 1 comment
Assignees
@TimPietrusky
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@TimPietrusky
Copy link
Member

TimPietrusky commented Apr 21, 2019 •
edited
Loading

Right now it's not possible to change the IP or host of either Thorium or luminave-server from the outside without updating the code. This means that when Thorium is running production-mode, it will not work. Also we can't change the port of luminave-server.

ToDo

  • Thorium: IP / port OR if the IP should be fetched automagically using bonjour
  • luminave-server: IP / port
  • Debug mode: Enable or disable log messages
@TimPietrusky TimPietrusky added enhancement New feature or request good first issue Good for newcomers labels Apr 21, 2019
@TimPietrusky TimPietrusky self-assigned this Apr 21, 2019
@TimPietrusky TimPietrusky changed the title Configuration for IP & host of Thorium & luminave-server External configuration Apr 21, 2019
TimPietrusky added a commit that referenced this issue May 27, 2019
@TimPietrusky
feat(config): Added dotenv
1c0dfe4 
#2
@TimPietrusky
Copy link
Member Author

Debug mode can be set, but when you set the NODE_ENV it will still not work, because webpack will overwrite it with it's mode option. This will be fixed in #3

TimPietrusky pushed a commit that referenced this issue May 27, 2019
@semantic-release-bot
chore(release): 1.2.0 [skip ci]
d5c3525 
# [1.2.0](v1.1.0...v1.2.0) (2019-05-27)

### Features

* **config:** Added dotenv ([1c0dfe4](1c0dfe4)), closes [#2](#2)
* **config:** Externalized configuration & added debugMode ([29bef08](29bef08)), closes [#2](#2)
* **graphql:** Set animation in luminave-server ([9b4d4a5](9b4d4a5))
TimPietrusky added a commit that referenced this issue May 27, 2019
@TimPietrusky
docs(config): Better example config with notes
248f6b4 
#2
TimPietrusky added a commit that referenced this issue May 27, 2019
@TimPietrusky
docs(config): Added "bash" formatting for config.
7b40579 
#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimPietrusky TimPietrusky

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TimPietrusky