Support CUDA compilation with Clang compiler #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- protect NVCC flags with gen-expr - GPU "CALLABLE" -> TIMEMORY macros - Use __CUDACC__ instead of __NVCC__ - _TIMEMORY_OPENMP_TARGET guards - disable cupti_counters for CUDA 11 - define malloc_gotcha types explicitly - threading::affinity::set - CI testing for cuda + clang
- _UNIX == TIMEMORY_UNIX - _LINUX == TIMEMORY_LINUX - _WINDOWS == TIMEMORY_WINDOWS - _MACOS == TIMEMORY_MACOS - Added tests when kokkos sample is built - Updated kokkos-common memory_entry_t to use user_kokkosp_bundle
- TIMEMORY_LIBRARY_SOURCE - Fix visibility for kp_timemory on linux - Fix weak binding on macOS - Better data_tracker_tests
Codecov Report
@@ Coverage Diff @@
## develop #161 +/- ##
===========================================
+ Coverage 82.60% 82.70% +0.11%
===========================================
Files 240 240
Lines 16238 16245 +7
===========================================
+ Hits 13411 13434 +23
+ Misses 2827 2811 -16
Continue to review full report at Codecov.
|
jrmadsen
added a commit
that referenced
this pull request
Jun 28, 2021
* Added support for cuda compilation with clang * Miscellaneous updates for clang + cuda - protect NVCC flags with gen-expr - GPU "CALLABLE" -> TIMEMORY macros - Use __CUDACC__ instead of __NVCC__ - _TIMEMORY_OPENMP_TARGET guards - disable cupti_counters for CUDA 11 - define malloc_gotcha types explicitly - threading::affinity::set - CI testing for cuda + clang * Removed error check * Macro updates + kokkos tests - _UNIX == TIMEMORY_UNIX - _LINUX == TIMEMORY_LINUX - _WINDOWS == TIMEMORY_WINDOWS - _MACOS == TIMEMORY_MACOS - Added tests when kokkos sample is built - Updated kokkos-common memory_entry_t to use user_kokkosp_bundle * Update add_secondary.hpp * CI updates * Find launch_compiler component when finding Kokkos * Fix to TIMEMORY_PYTHON_PLOTTER pre-processor def * Use separable compilation for kokkos instead of launch_compiler * cmake_defines fixes for default * Update kokkos_compilation usage * Enable HW counters for CUDA 11 * Kokkos-connector updates * Remove kokkos_compilation macro usage * More kokkos-connector updates * Testing updates * Miscellaneous testing fixes - TIMEMORY_LIBRARY_SOURCE - Fix visibility for kp_timemory on linux - Fix weak binding on macOS - Better data_tracker_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_CUDA_COMPILER=clang++or (via env)CUDACXX=clang++GLOBAL_CALLABLEtoTIMEMORY_GLOBAL_FUNCTION, etc._UNIX,_MACOS, etc. toTIMEMORY_UNIX,TIMEMORY_MACOS, etc.__NVCC__with__CUDACC___TIMEMORY_OPENMP_TARGETfor OpenMP target compilation with timemory since OpenMP target may define__CUDACC__but won't allow compiling raw CUDATIMEMORY_FOLD_EXPRESSION(...)implements C++17 fold expressions instead of C++14 fold expression via initializer list