Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for future maintainability #13

Merged
merged 6 commits into from May 10, 2023
Merged

Refactor for future maintainability #13

merged 6 commits into from May 10, 2023

Conversation

martialblog
Copy link
Member

@martialblog martialblog commented May 9, 2023 •
edited

  • Add tests and linting
  • Remove request requirement by using Python's urllib
  • More robust error handling and output generation
  • General Refactor for smoother code 馃幒

@martialblog martialblog marked this pull request as ready for review May 9, 2023 15:12
@martialblog martialblog self-assigned this May 9, 2023
@martialblog martialblog added this to the v3.0.0 milestone May 9, 2023
RincewindsHat
RincewindsHat approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@RincewindsHat RincewindsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me on a glance

@martialblog
Copy link
Member Author 

python -m coverage report -m --include check_brevisone.py
Name              Stmts   Miss  Cover   Missing
-----------------------------------------------
check_brevisone      79      5    94%   85-86, 199-201
-----------------------------------------------
TOTAL                79      5    94%

Good enough

@martialblog martialblog merged commit e5407d8 into master May 10, 2023
2 checks passed
@martialblog martialblog deleted the refactor/update-2023 branch May 10, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RincewindsHat RincewindsHat RincewindsHat approved these changes

@tbauriedel tbauriedel Awaiting requested review from tbauriedel

Assignees

@martialblog martialblog

Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martialblog @RincewindsHat