Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and refactor for testing #1

Merged
merged 11 commits into from
Aug 2, 2023
Merged

Add tests and refactor for testing #1

merged 11 commits into from
Aug 2, 2023

Conversation

martialblog
Copy link
Member

@martialblog martialblog commented Aug 2, 2023

This PR adds unittesting and includes a small refactor for readability, testability and bugfixes

  • Change output format (to enable formatting in Icinga2)
  • Improve error handling except e: probably never worked
  • Add testcases for all functions
  • Refactor argparse for simpler testing
  • Add linter and fix linting issues
  • Add version output
  • Add GitHub Action configuration
  • Update .gitignore

@martialblog martialblog self-assigned this Aug 2, 2023
@martialblog martialblog marked this pull request as ready for review August 2, 2023 15:08
@martialblog martialblog changed the title Add tests and minor refactor for testing Add tests and refactor for testing Aug 2, 2023
@martialblog martialblog requested a review from mxhash August 2, 2023 15:11
@martialblog
Copy link
Member Author

Name                   Stmts   Miss  Cover   Missing
----------------------------------------------------
check_mumble_ping.py      33      0   100%
----------------------------------------------------
TOTAL                     33      0   100%

🎤 ✋

@martialblog martialblog merged commit c326867 into master Aug 2, 2023
2 checks passed
@martialblog martialblog deleted the chore/add-tests branch August 2, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant