Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pylint and unittests #9

Merged
merged 7 commits into from May 15, 2023
Merged

Add pylint and unittests #9

merged 7 commits into from May 15, 2023

Conversation

martialblog
Copy link
Member

  • Add automated unittests from testdata already present in the repo. Includes a small refactor for the CLI to ease testing
  • Add pylint and fix minor linting issues
  • Change default return code when asking for the version to 3 (UNKNOWN)
  • Change validation of HTTP Return code. Now allows for everything below 400
  • Change --mode arg to be a choice, so that the user knows what can be selected

@martialblog martialblog self-assigned this May 13, 2023
@martialblog
Copy link
Member Author

TODO: UTC on runners causes tests to fail

@martialblog
Copy link
Member Author

Set constant timezone for tests

RincewindsHat
RincewindsHat reviewed May 14, 2023
View reviewed changes
Copy link
Member

@RincewindsHat RincewindsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

check_vmware_nsxt.py Show resolved Hide resolved
@martialblog
Remove URL TODO
10f502d 
- requests already causes an [CRITICAL] Invalid URL error
RincewindsHat
RincewindsHat approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@RincewindsHat RincewindsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go

@martialblog martialblog merged commit ba72621 into main May 15, 2023
2 checks passed
@martialblog martialblog deleted the chore/add-tests branch May 15, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RincewindsHat RincewindsHat RincewindsHat approved these changes

Assignees

@martialblog martialblog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martialblog @RincewindsHat